fix: use Animated.View for RainbowToast inner content container#7336
Merged
janicduplessis merged 1 commit intodevelopfrom Apr 13, 2026
Merged
fix: use Animated.View for RainbowToast inner content container#7336janicduplessis merged 1 commit intodevelopfrom
janicduplessis merged 1 commit intodevelopfrom
Conversation
Replace plain View with Animated.View for the inner content container that receives an animated style (contentContainerStyle). Applying animated styles to non-animated host components causes issues on the new architecture.
|
π§ͺ Flashlight Performance Report (AWS Device Farm) π Commit: 370594e π View Artifacts
|
olerass
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-3621
What changed (plus any additional context for devs)
Extracted from the new arch migration PR #6924.
The
RainbowToastinner content container receives an animated style (contentContainerStyleβ aminWidthspring animation) but uses a plainViewas the host component. On new arch, applying Reanimated animated styles to non-animated host components does not work.Note: on current arch (Paper), the animated style on a plain
Viewis silently ignored, meaning theminWidthspring animation was never actually running. Switching toAnimated.Viewwill make it work for the first time β the toast width will now animate smoothly when content changes rather than snapping. This should look better but is worth verifying visually.What to test
Screen.Recording.2026-04-10.at.4.46.36.PM.mov