fix: inline time utility worklet calculations#7335
Merged
janicduplessis merged 1 commit intodevelopfrom Apr 13, 2026
Merged
Conversation
Replace recursive worklet-to-worklet calls with inline math in time utility functions. Calling one worklet from another worklet can fail in newer Reanimated/worklet runtimes.
|
π§ͺ Flashlight Performance Report (AWS Device Farm) π Commit: 365cde2 π View Artifacts
|
Contributor
Author
|
Not tested manually, partially covered by unit tests and obvious fix. |
olerass
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-3620
What changed (plus any additional context for devs)
Extracted from the new arch migration PR #6924.
The
timeutility functions (minutes,hours,days,weeks) use recursive worklet-to-worklet calls (e.g.,time.minutes()callstime.seconds()). In newer Reanimated and worklet runtimes required for new arch, calling one worklet function from inside another worklet fails due to how worklet closures are serialized.Replaces recursive calls with inline arithmetic. Each function now directly computes milliseconds instead of delegating to another worklet. The results are identical.
What to test
Tested previously in the RN upgrade branch, verified the error happened before and not after this fix.
yarn jest src/state/internal/queryStore/queryStore.test.tsβ exercisestime.minutes()andtime.days()for cache/stale time configs