fix: round zIndex value in useAnimatedTab for Fabric compatibility#7332
Merged
janicduplessis merged 1 commit intodevelopfrom Apr 15, 2026
Merged
fix: round zIndex value in useAnimatedTab for Fabric compatibility#7332janicduplessis merged 1 commit intodevelopfrom
janicduplessis merged 1 commit intodevelopfrom
Conversation
Fabric requires integer zIndex values. The computed zIndex from scaleWeighting multiplication can produce floats, causing issues on the new architecture.
|
π§ͺ Flashlight Performance Report (AWS Device Farm) π Commit: 3909eb8 π View Artifacts
|
olerass
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-3617
What changed (plus any additional context for devs)
Extracted from the new arch migration PR #6924.
The browser tab view computes a
zIndexvalue by multiplyingscaleWeightingwith constants, which can produce floating-point values. Fabric (new arch) requireszIndexto be an integer or it will crash.What to test
Tested previously in the RN upgrade branch