Skip to content

fsdp: assert weight-sync grouping covers the train world #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhihengy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fsdp: assert weight-sync grouping covers the train world #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions miles/backends/fsdp_utils/diffusion_update_weight_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,18 @@ def connect_rollout_engines(
) -> None:
self.rollout_engines = rollout_engines

# Match rollout.init_rollout_engines' per-engine span; a mismatch would
# leave orphaned ranks that fail much later in update_bucket_weights.
num_gpu_per_engine = min(self.args.rollout_num_gpus_per_engine, self.args.num_gpus_per_node)
assert dist.get_world_size() == len(rollout_engines) * num_gpu_per_engine, (
f"train world {dist.get_world_size()} != {len(rollout_engines)} engines x "
f"{num_gpu_per_engine} gpus per engine"
)

# Here we assume the gpu id of rollout engines and train actors are the same.
for i, engine in enumerate(self.rollout_engines):
start_rank = i * self.args.rollout_num_gpus_per_engine
end_rank = (i + 1) * self.args.rollout_num_gpus_per_engine
start_rank = i * num_gpu_per_engine
end_rank = (i + 1) * num_gpu_per_engine
group_ranks = list(range(start_rank, end_rank))
new_group = dist.new_group(
ranks=group_ranks,
Expand Down
Loading