fix: bracket IPv6 hosts in distributed init methods#1636
Open
EazyReal wants to merge 1 commit into
Open
Conversation
torch.distributed tcp init URLs require brackets around IPv6 literals. Bare node addresses otherwise produce ambiguous URLs such as tcp://fe80::1:29500. Use the existing _wrap_ipv6 helper at all three NCCL process-group initialization paths. IPv4 addresses and hostnames remain unchanged. Add integration coverage for IPv6 and IPv4 URL construction.
EazyReal
requested review from
Shi-Dong,
Zhichenzzz,
fzyzcjy,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds IPv6 support for process group initialization across several backend utilities by wrapping the master address with _wrap_ipv6. It also adds a unit test to verify that the initialization method is correctly formatted for both IPv4 and IPv6 addresses. There are no review comments to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the existing IPv6 wrapper for all actor/critic and weight-update tcp init methods.
Why
Bare IPv6 node addresses make torch.distributed rendezvous URLs ambiguous. This extends the Slime fix from THUDM/slime#2151 to the additional Miles call sites while leaving IPv4 and hostnames unchanged.
Testing
pytest -q tests/fast/backends/test_ipv6_init_method.py