-
Notifications
You must be signed in to change notification settings - Fork 308
[OPD] Stabilize two-node GB200 HybridEP training #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: opd-qwen3p5-35b-selfdistill
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -74,7 +74,22 @@ def _allocate_gpus_for_actor(self, pg, num_gpus_per_actor): | |||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||
| assert os.path.exists(dynlib_path), f"LD_PRELOAD so file {dynlib_path} does not exist." | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| env_vars["LD_PRELOAD"] = dynlib_path | ||||||||||||||||||||||||||
| preload_libs = [] | ||||||||||||||||||||||||||
| shm_compat_lib = os.environ.get("TORCH_SHM_UNLINK_COMPAT_LIB") | ||||||||||||||||||||||||||
| if shm_compat_lib: | ||||||||||||||||||||||||||
| assert os.path.exists( | ||||||||||||||||||||||||||
| shm_compat_lib | ||||||||||||||||||||||||||
| ), f"torch shared-memory cleanup library {shm_compat_lib} does not exist." | ||||||||||||||||||||||||||
| preload_libs.append(shm_compat_lib) | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| trace_lib = os.environ.get("TMS_CUMEM_TRACE_LIB") | ||||||||||||||||||||||||||
| if trace_lib: | ||||||||||||||||||||||||||
| assert os.path.exists(trace_lib), f"cuMemCreate trace library {trace_lib} does not exist." | ||||||||||||||||||||||||||
| preload_libs.append(trace_lib) | ||||||||||||||||||||||||||
| env_vars["CUMEM_TRACE_ALL"] = os.environ.get("CUMEM_TRACE_ALL", "") | ||||||||||||||||||||||||||
|
Comment on lines
+85
to
+89
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Setting
Suggested change
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| preload_libs.append(dynlib_path) | ||||||||||||||||||||||||||
| env_vars["LD_PRELOAD"] = ":".join(preload_libs) | ||||||||||||||||||||||||||
| env_vars["TMS_INIT_ENABLE"] = "1" | ||||||||||||||||||||||||||
| env_vars["TMS_INIT_ENABLE_CPU_BACKUP"] = "1" | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
torch.cuda.current_device()directly can lead to device mismatch errors ifreplay_datais already on a specific CUDA device that differs from the active current device context. To make this more robust, we should usereplay_data.deviceif it is a CUDA tensor, and fall back totorch.cuda.current_device()otherwise.