fix(react): stabilize composed ref identities to end React 19 render loop (#3963)

[nakisgr]

Summary

Follows up on #3899, which stabilized Slot's composed ref to fix the React 19 infinite re-render loop. The same unstable-identity pattern still exists in several other packages' own code, and under React 19's ref-cleanup semantics each reproduces the same Maximum update depth exceeded crash.

useComposedRefs is React.useCallback(composeRefs(...refs), refs). When a member of refs is an inline arrow (or the composition is a bare composeRefs(...) in render), the composed callback gets a new identity every render. React 19 detaches/re-attaches the ref on every commit; any composed state-setter ref toggles null -> node each cycle, scheduling another render — an infinite loop.

Changes

Same principle as #3899 — give the composed refs a stable identity:

• Pass state setters directly (useComposedRefs(forwardedRef, setX)), matching existing usage like select.tsx onTriggerChange:
  • react-dismissable-layer: DismissableLayer → setNode
  • react-focus-scope: FocusScope → setContainer
  • react-popper: PopperContent → setContent
  • react-scroll-area: ScrollArea → setScrollArea, Scrollbar → setScrollbar, Thumb → scrollbarContext.onThumbChange (already stabilized via useCallbackRef)
  • react-select: SelectContentImpl / SelectItemAlignedPosition → setContent, SelectItemText → setItemTextNode
• Hoist render-inline composeRefs(...) into useComposedRefs above the JSX:
  • react-dropdown-menu: DropdownMenuTrigger
  • react-menu: MenuSubTrigger (composed directly with the onTriggerChange state setter)
• Wrap closures that capture per-render values in useCallbackRef before composing (they take extra args, so can't be passed directly):
  • react-select: SelectItem (value, disabled) and SelectItemText (value, disabled)

Notes

• Changes are mechanical and behavior-preserving; identities are now stable across renders.
• react-dismissable-layer is emphasized in [React 19] Unstable composed-ref identities in several primitives still cause "Maximum update depth exceeded" after the Slot fix (#3899) #3963 as the residual loop driver, since it wraps every menu/popover/dialog content stack.

Closes #3963.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 20c8435

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR