Add by_semester method, for the 6-month intervals of the year - #88
Open
morellan wants to merge 2 commits into
Open
Add by_semester method, for the 6-month intervals of the year#88morellan wants to merge 2 commits into
morellan wants to merge 2 commits into
Conversation
Collaborator
|
Hi, this looks fine to merge, however, can you first help fix the failing Travis tests? (I realize they aren't caused by your PR) |
Author
|
Happy to help, but I'm not sure where to start since most of the errors are caused by some problem in the CI |
morellan
force-pushed
the
add-by-semester
branch
from
August 1, 2020 17:56
2dbd05b to
45ca5ad
Compare
Collaborator
|
Thanks! Will merge when CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using this extra method to check if something happened in the first half or second half of the year, I hope this could be useful for others.