Skip to content

Print parameters of TIME and TIMESTAMP types in schemas - #184

Merged
gaborcsardi merged 3 commits into
r-lib:mainfrom
m-muecke:fix-print-time-timestamp
Oct 15, 2026
Merged

Print parameters of TIME and TIMESTAMP types in schemas#184
gaborcsardi merged 3 commits into
r-lib:mainfrom
m-muecke:fix-print-time-timestamp

Conversation

@m-muecke

@m-muecke m-muecke commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

One could also rename the slot name thats stored in the list.

@gaborcsardi

gaborcsardi commented Oct 14, 2026

Copy link
Copy Markdown
Member

The official name is isAdjustedToUTC, so ideally we'd indeed rename it to is_adjusted_to_utc everywhere. Strictly speaking it is a breaking change. But I would not expect many people relying on this right now, so how about renaming it?

@m-muecke

m-muecke commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

strongly agree

@gaborcsardi
Allow the old is_adjusted_utc name in parquet_schema()
47be245 
Plus adjust NEWS.md, `parquet_type()` is not an exported function,
no need to mention that.
@gaborcsardi
gaborcsardi merged commit 5fd2cae into r-lib:main Oct 15, 2026
22 checks passed
@gaborcsardi

gaborcsardi commented Oct 15, 2026

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m-muecke @gaborcsardi