Factor setup#31
Merged
Merged
Conversation
kba
approved these changes
Jun 15, 2021
Collaborator
kba
left a comment
kba
left a comment
There was a problem hiding this comment.
The setup and docstring changes as well as the {,self}.binarizer fix are clear improvements. For the TF session management changes, @vahidrezanezhad or @mikegerber know better about any potential pitfalls. To me, it looks good.
cneud
approved these changes
Apr 19, 2022
Member
cneud
left a comment
cneud
left a comment
There was a problem hiding this comment.
LGTM, thx @bertsky!
(@vahidrezanezhad can you plz also check and sign off?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of upcoming API changes – notably automatic page-level parallelism and page-level failover – this factors out the model loading from
process()and from the constructor into a dedicated, conventionalsetup()(which will be required/used by the Processor base class in core soon, at which point there will be no need to call it from the inherited constructor).Note that this also already enables running sbb-binarize in the workflow server prototype.
The second change is necessary if you have multiple TF sessions in your server: each must store its session and reload it just prior to running the graph.