[WIP] RPM packaging doesn't flag .NET Core DLLs as executables

.gitignore

@@ -5,3 +5,9 @@ obj/
 .vs/
 .idea/
 .vagrant/
+*.deb
+*.rpm
+*.msi
+*.pkg
+*.zip
+*.tar.gz

.travis.yml

@@ -0,0 +1,35 @@
+language: csharp
+mono: none
+dotnet: 2.1.400
+
+env:
+  - RUNTIME=centos.7-x64
+  - RUNTIME=ol.7-x64
+  - RUNTIME=fedora.27-x64
+  - RUNTIME=fedora.28-x64
+  - RUNTIME=debian.8-x64
+  - RUNTIME=debian.9-x64
+  - RUNTIME=ubuntu.14.04-x64
+  - RUNTIME=ubuntu.16.04-x64
+  - RUNTIME=ubuntu.18.04-x64
+  - RUNTIME=opensuse.42.3-x64
+
+sudo: required
+
+git:
+  depth: false
+
+script:
+  - dotnet restore dotnet-packaging.sln
+  - dotnet pack dotnet-packaging.sln -c Release
+  - dotnet test Packaging.Targets.Tests/Packaging.Targets.Tests.csproj
+
+  - cd $TRAVIS_BUILD_DIR/demo/aspnetcore
+  - dotnet restore
+  - if [ "$RUNTIME" = "rhel.7-x64" ]; then dotnet rpm -c Release -r rhel.7-x64 -f netcoreapp2.0; fi
+  - if [ "$RUNTIME" = "ubuntu.16.04-x64" ]; then dotnet deb -c Release -r ubuntu.16.04-x64 -f netcoreapp2.0; fi
+
+  - cd $TRAVIS_BUILD_DIR/demo/cliscd/
+  - dotnet restore
+
+  - ./run-tests.sh -r $RUNTIME

.vscode/launch.json

@@ -0,0 +1,28 @@
+{
+   // Use IntelliSense to find out which attributes exist for C# debugging
+   // Use hover for the description of the existing attributes
+   // For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md
+   "version": "0.2.0",
+   "configurations": [
+        {
+            "name": ".NET Core Launch (console)",
+            "type": "coreclr",
+            "request": "launch",
+            "preLaunchTask": "build",
+            // If you have changed target frameworks, make sure to update the program path.
+            "program": "${workspaceFolder}/dotnet-deb/bin/Debug/netcoreapp1.0/dotnet-deb.dll",
+            "args": [],
+            "cwd": "${workspaceFolder}/dotnet-deb",
+            // For more information about the 'console' field, see https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md#console-terminal-window
+            "console": "internalConsole",
+            "stopAtEntry": false,
+            "internalConsoleOptions": "openOnSessionStart"
+        },
+        {
+            "name": ".NET Core Attach",
+            "type": "coreclr",
+            "request": "attach",
+            "processId": "${command:pickProcess}"
+        }
+    ,]
+}

.vscode/tasks.json

@@ -0,0 +1,15 @@
+{
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "label": "build",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "build",
+                "${workspaceFolder}/dotnet-deb/dotnet-deb.csproj"
+            ],
+            "problemMatcher": "$msCompile"
+        }
+    ]
+}

Packaging.Targets.Tests/ArchiveBuilderTests.cs

@@ -3,6 +3,7 @@
 using Packaging.Targets.IO;
 using System;
 using System.Collections.Generic;
+using System.IO;
 using Xunit;
 
 namespace Packaging.Targets.Tests
@@ -31,7 +32,7 @@ public void FromDirectoryTest()
             Assert.Equal(LinuxFileMode.S_IROTH |  LinuxFileMode.S_IRGRP |  LinuxFileMode.S_IRUSR | LinuxFileMode.S_IFREG, readme.Mode);
             Assert.Equal("root", readme.Owner);
             Assert.False(readme.RemoveOnUninstall);
-            Assert.Equal("archive\\README.md", readme.SourceFilename);
+            Assert.Equal(Path.Combine("archive", "README.md"), readme.SourceFilename);
             Assert.Equal("/opt/demo/README.md", readme.TargetPath);
             Assert.Equal("/opt/demo/README.md", readme.TargetPathWithFinalSlash);
             Assert.Equal(ArchiveEntryType.None, readme.Type);
@@ -44,7 +45,7 @@ public void FromDirectoryTest()
             Assert.Equal(LinuxFileMode.S_IROTH | LinuxFileMode.S_IRGRP | LinuxFileMode.S_IRUSR | LinuxFileMode.S_IFREG, script.Mode);
             Assert.Equal("root", script.Owner);
             Assert.False(script.RemoveOnUninstall);
-            Assert.Equal("archive\\script.sh", script.SourceFilename);
+            Assert.Equal(Path.Combine("archive", "script.sh"), script.SourceFilename);
             Assert.Equal("/opt/demo/script.sh", script.TargetPath);
             Assert.Equal("/opt/demo/script.sh", script.TargetPathWithFinalSlash);
             Assert.Equal(ArchiveEntryType.None, script.Type);
@@ -79,7 +80,7 @@ public void FromDirectoryWithMetadataTest()
             Assert.Equal(LinuxFileMode.S_IROTH | LinuxFileMode.S_IRGRP | LinuxFileMode.S_IRUSR | LinuxFileMode.S_IFREG, readme.Mode);
             Assert.Equal("root", readme.Owner);
             Assert.False(readme.RemoveOnUninstall);
-            Assert.Equal("archive\\README.md", readme.SourceFilename);
+            Assert.Equal(Path.Combine("archive", "README.md"), readme.SourceFilename);
             Assert.Equal("/opt/demo/README.md", readme.TargetPath);
             Assert.Equal("/opt/demo/README.md", readme.TargetPathWithFinalSlash);
             Assert.Equal(ArchiveEntryType.None, readme.Type);
@@ -94,7 +95,7 @@ public void FromDirectoryWithMetadataTest()
             Assert.Equal(LinuxFileMode.S_IXOTH | LinuxFileMode.S_IROTH | LinuxFileMode.S_IXGRP | LinuxFileMode.S_IRGRP | LinuxFileMode.S_IXUSR | LinuxFileMode.S_IWUSR | LinuxFileMode.S_IRUSR, script.Mode);
             Assert.Equal("root", script.Owner);
             Assert.False(script.RemoveOnUninstall);
-            Assert.Equal("archive\\script.sh", script.SourceFilename);
+            Assert.Equal(Path.Combine("archive", "script.sh"), script.SourceFilename);
             Assert.Equal("/bin/script.sh", script.TargetPath);
             Assert.Equal("/bin/script.sh", script.TargetPathWithFinalSlash);
             Assert.Equal(ArchiveEntryType.None, script.Type);

Packaging.Targets.Tests/Rpm/RpmMetadataTests.cs

@@ -117,7 +117,7 @@ public void SetFilesTest()
                 {
                     ArchiveBuilder builder = new ArchiveBuilder(new PlistFileAnalyzer());
                     RpmPackageCreator creator = new RpmPackageCreator(new PlistFileAnalyzer());
-                    var entries = builder.FromCpio(cpio);
+                    var entries = builder.FromCpio(originalPackage, cpio);
                     var files = creator.CreateFiles(entries);
 
                     var metadata = new PublicRpmMetadata(package);
@@ -186,7 +186,7 @@ public void CreatePackageMetadata()
                 {
                     ArchiveBuilder builder = new ArchiveBuilder(new PlistFileAnalyzer());
                     RpmPackageCreator creator = new RpmPackageCreator(new PlistFileAnalyzer());
-                    var entries = builder.FromCpio(cpio);
+                    var entries = builder.FromCpio(originalPackage, cpio);
                     var files = creator.CreateFiles(entries);
 
                     // Core routine to populate files and dependencies

Packaging.Targets.Tests/Rpm/RpmPackageCreatorTests.cs

@@ -46,7 +46,7 @@ public void CreateFiles(string rpm, string analyzerName)
 
                     RpmPackageCreator creator = new RpmPackageCreator(analyzer);
                     ArchiveBuilder builder = new ArchiveBuilder(analyzer);
-                    var entries = builder.FromCpio(cpio);
+                    var entries = builder.FromCpio(originalPackage, cpio);
                     var files = creator.CreateFiles(entries);
 
                     var originalMetadata = new RpmMetadata(originalPackage);
@@ -98,7 +98,7 @@ public void CalculateOffsetTest()
                 {
                     ArchiveBuilder builder = new ArchiveBuilder(new PlistFileAnalyzer());
                     RpmPackageCreator creator = new RpmPackageCreator(new PlistFileAnalyzer());
-                    var entries = builder.FromCpio(cpio);
+                    var entries = builder.FromCpio(originalPackage, cpio);
                     var files = creator.CreateFiles(entries);
 
                     // Core routine to populate files and dependencies
@@ -151,7 +151,7 @@ public void CalculateSignatureTest()
                 using (var cpio = new CpioFile(payloadStream, false))
                 {
                     ArchiveBuilder builder = new ArchiveBuilder(new PlistFileAnalyzer());
-                    var entries = builder.FromCpio(cpio);
+                    var entries = builder.FromCpio(originalPackage, cpio);
                     files = creator.CreateFiles(entries);
                 }
 
@@ -242,8 +242,16 @@ public void CreatePackageTest()
             var secretKeyRing = krgen.GenerateSecretKeyRing();
             var privateKey = secretKeyRing.GetSecretKey().ExtractPrivateKey("dotnet".ToCharArray());
             var publicKey = secretKeyRing.GetPublicKey();
-
-            using (Stream stream = File.OpenRead(@"Rpm/libplist-2.0.1.151-1.1.x86_64.rpm"))
+            const string preInstScript = "echo preinst\n";
+            const string postInstScript = "echo postinst\n";
+            const string preRemoveScript = "echo preremove\n";
+            const string postRemoveScript = "echo postremove\n";
+            const string nameString = "libplist";
+            const string versionString = "2.0.1.151";
+            const string releaseString = "1.1";
+            const string archString = "x86_64";
+
+            using (Stream stream = File.OpenRead($"Rpm/{nameString}-{versionString}-{releaseString}.{archString}.rpm"))
             using (var targetStream = File.Open(@"RpmPackageCreatorTests_CreateTest.rpm", FileMode.Create, FileAccess.ReadWrite, FileShare.None))
             {
                 var originalPackage = RpmPackageReader.Read(stream);
@@ -253,7 +261,7 @@ public void CreatePackageTest()
                 using (CpioFile cpio = new CpioFile(decompressedPayloadStream, leaveOpen: false))
                 {
                     ArchiveBuilder builder = new ArchiveBuilder();
-                    archive = builder.FromCpio(cpio);
+                    archive = builder.FromCpio(originalPackage, cpio);
                 }
 
                 using (var decompressedPayloadStream = RpmPayloadReader.GetDecompressedPayloadStream(originalPackage))
@@ -266,15 +274,19 @@ public void CreatePackageTest()
                     creator.CreatePackage(
                         archive,
                         payloadStream,
-                        "libplist",
-                        "2.0.1.151",
-                        "x86_64",
-                        "1.1",
+                        nameString,
+                        versionString,
+                        archString,
+                        releaseString,
                         false,
                         null,
                         false,
                         null,
                         null,
+                        preInstScript,
+                        postInstScript,
+                        preRemoveScript,
+                        postRemoveScript,
                         null,
                         (metadata) => PlistMetadata.ApplyDefaultMetadata(metadata),
                         privateKey,
@@ -287,6 +299,14 @@ public void CreatePackageTest()
                 var package = RpmPackageReader.Read(targetStream);
 
                 var metadata = new RpmMetadata(package);
+                Assert.Equal(metadata.Version, versionString);
+                Assert.Equal(metadata.Name, nameString);
+                Assert.Equal(metadata.Arch, archString);
+                Assert.Equal(metadata.Release, releaseString);
+                Assert.StartsWith(preInstScript, metadata.PreIn);
+                Assert.StartsWith(postInstScript, metadata.PostIn);
+                Assert.StartsWith(preRemoveScript, metadata.PreUn);
+                Assert.StartsWith(postRemoveScript, metadata.PostUn);
                 var signature = new RpmSignature(package);
 
                 Assert.True(signature.Verify(publicKey));
@@ -318,7 +338,7 @@ public void CreatePackageBinaryTest()
                 using (CpioFile cpio = new CpioFile(decompressedPayloadStream, leaveOpen: false))
                 {
                     ArchiveBuilder builder = new ArchiveBuilder();
-                    archive = builder.FromCpio(cpio);
+                    archive = builder.FromCpio(originalPackage, cpio);
                 }
 
                 using (var compressedPayloadStream = RpmPayloadReader.GetCompressedPayloadStream(originalPackage))
@@ -337,6 +357,10 @@ public void CreatePackageBinaryTest()
                         null,
                         null,
                         null,
+                        null,
+                        null,
+                        null,
+                        null,
                         (metadata) => PlistMetadata.ApplyDefaultMetadata(metadata),
                         signer,
                         targetStream,