Clean headers#257
Open
Dmitry Baryshkov (lumag) wants to merge 7 commits into
Open
Conversation
Add GDSP-related libraries to lib_LTLIBRARIES, they were missed in the original commit. Fixes: 1ee463d ("Add changes to support GPDSPs offloading") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Stop declaring non-API functions in a fastrpc_notif.h Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
The dspqueue_sahred.h header is only used by dspqueue_cpu.c. Inline header contents into the corresponding file. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
In order to prevent extra confusion (and in preparation to integtating QAIC into the build process in future) move all QAIC-generated files to a separate location. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Contributor
Author
|
Why is the code being built with the compiler from 2019? The |
Dmitry Baryshkov (lumag)
force-pushed
the
clean-headers
branch
from
81c5c7b to
19f5f4a
Compare
Extract local API into a BSD-licensed copy of the upstream misc/fastrpc.h header. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Drop several headers (and source files) which are not longer user by anything. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Clean the API of fastrpc_ioctl.h header, dropping unused (or useless) defines. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Srinivas Kandagatla (Srinivas-Kandagatla)
approved these changes
Nov 13, 2025
Srinivas Kandagatla (Srinivas-Kandagatla)
left a comment
Srinivas Kandagatla (Srinivas-Kandagatla)
left a comment
There was a problem hiding this comment.
lgtm
Dmitry Baryshkov (lumag)
force-pushed
the
clean-headers
branch
from
19f5f4a to
658e837
Compare
| @@ -98,10 +98,12 @@ libsdsp_default_listener_la_CFLAGS = $(SDSP_CFLAGS) -DUSE_SYSLOG | |||
|
|
|||
| GDSP_CFLAGS = $(LIBDSPRPC_CFLAGS) -DDEFAULT_DOMAIN_ID=5 | |||
Contributor
There was a problem hiding this comment.
libgdsprpc was actually intended to not be added as we are sticking with multidomain-only approach for gdsp. Here domain is always passed explicitly and no need to rely on library to extract domain information. So we can basically reuse any existing library and just pass the domain name to make it work. (example: ./gdsprpcd rootpd gdsp0)
I think it would be better to remove libgdsprpc_la* and libgdsp_default_listener* completely and just build gdsprpcd.
|
This pull request has been marked as stale due to 60 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion in #253 , reorg headers and source files a bit.