Fix evaluation order of (before/in/after)-SECTIONS assignments#1203
Open
parth-07 wants to merge 1 commit into
Open
Fix evaluation order of (before/in/after)-SECTIONS assignments#1203parth-07 wants to merge 1 commit into
parth-07 wants to merge 1 commit into
Conversation
quic-seaswara
approved these changes
May 22, 2026
parth-07
force-pushed
the
AssignmentEvaluationOrder
branch
from
258b4d0 to
adea124
Compare
Until now, eld used to incorrectly evaluate before SECTIONS and after SECTIONS assignments both before and after the in-SECTIONS assignments. This results in incorrect linker script symbol values and incorrect layout. This patch fixes the linker script assignment evaluation order. Now, we evaluate the assignments after the SECTIONS command as part of the layout re-iteration loop in create(Script)ProgramHeaders. One of the key design change in this patch is to store AfterSections assignments with the last output section. It is required to properly evaluate the assignments when the link contains multiple SECTIONS commands. Resolves qualcomm#430 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
parth-07
force-pushed
the
AssignmentEvaluationOrder
branch
from
adea124 to
00d10a3
Compare
Contributor
quic-seaswara
left a comment
quic-seaswara
left a comment
There was a problem hiding this comment.
How does the map file print the assignments, can you please add a test ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, eld used to incorrectly evaluate before SECTIONS and after SECTIONS assignments both before and after the in-SECTIONS assignments. This results in incorrect linker script symbol values and incorrect layout.
This patch fixes this linker script assignment evaluation order. Now, we evaluate the assignments after the SECTIONS command as part of the layout re-iteration loop in create(Script)ProgramHeaders.
One of the key design change in this patch is to store AfterSections assignments with the last output section. It is required to properly evaluate the assignments when the link contains multiple SECTIONS commands.
Resolves #430