shikra-evk: add phone to MACHINE_FEATURES by mdembla-bit · Pull Request #2665 · qualcomm-linux/meta-qcom

Mrigank Dembla (mdembla-bit) · 2026-07-01T09:59:36Z

shikra-evk does not support cellular data calls, as modemmanager is
not enabled for this machine.

modemmanager is conditionally enabled at the distro layer based on
'phone' being present in a machine's MACHINE_FEATURES. Add 'phone'
to MACHINE_FEATURES for shikra-evk so that modemmanager gets enabled
and cellular data connectivity is supported.

Dmitry Baryshkov (lumag)

Pleasev start your commit message by describing the issue you are trying to solve.

Mrigank Dembla (mdembla-bit) · 2026-07-01T10:53:02Z

Pleasev start your commit message by describing the issue you are trying to solve.

Hi Dmitry Baryshkov (@lumag) , updated the commit text, as well as PR description. Please let me know if this is fine?

Dmitry Baryshkov (lumag) · 2026-07-01T12:17:18Z

Pleasev start your commit message by describing the issue you are trying to solve.

Please let me know if this is fine?

Did you start your commit message with the description of the issue? No, you didn't. So you can guess my answer. Also please drop the description of the change. "This change does this" is completely redundant, you can see it from the patch itself. Why do you need to repeat yourself?

Mrigank Dembla (mdembla-bit) · 2026-07-01T15:49:19Z

Pleasev start your commit message by describing the issue you are trying to solve.

Please let me know if this is fine?

Did you start your commit message with the description of the issue? No, you didn't. So you can guess my answer. Also please drop the description of the change. "This change does this" is completely redundant, you can see it from the patch itself. Why do you need to repeat yourself?

I've updated the commit message based on your feedback to better explain the problem being solved and the role of phone in enabling ModemManager support.
Could you please take another look?

Dmitry Baryshkov (lumag)

Why do we want to support cellular calls on Shikra?

github-actions · 2026-07-01T20:02:55Z

Test run workflow

Test jobs for commit `7e00ed5`

nodistro
Pass: 10 | Fail: 0 | Total: 10

qcom-distro_linux-qcom-6.18
Pass: 218 | Fail: 0 | Total: 241

qcom-distro
Pass: 9 | Fail: 1 | Total: 10

test-reporting-app · 2026-07-01T20:03:31Z

Test Results

110 files 657 suites 7h 38m 50s ⏱️
162 tests 125 ✅ 2 💤 35 ❌
6 237 runs 6 123 ✅ 64 💤 50 ❌

For more details on these failures, see this check.

Results for commit 2e15d74.

♻️ This comment has been updated with latest results.

Mrigank Dembla (mdembla-bit) · 2026-07-02T03:31:06Z

Why do we want to support cellular calls on Shikra?

Shikra includes modem support and cellular data connectivity is an expected platform capability. This change enables the standard ModemManager userspace stack required to make use of the modem for WWAN data calls.

Dmitry Baryshkov (lumag) · 2026-07-02T05:27:12Z

Shikra includes modem support and cellular data connectivity is an expected platform capability

This should be a part of the commit message. Which board has a modem? Is it a PCIe modem or a part of the SoC, etc.

Mrigank Dembla (mdembla-bit) · 2026-07-02T11:04:02Z

Shikra includes modem support and cellular data connectivity is an expected platform capability

This should be a part of the commit message. Which board has a modem? Is it a PCIe modem or a part of the SoC, etc.

Thanks. I've updated the commit message accordingly. It now explicitly states that shikra-evk requires WWAN connectivity support for the modem integrated into the SoC and explains that the phone MACHINE_FEATURE is needed to enable the required ModemManager userspace support.

Dmitry Baryshkov (lumag)

shikra-evk lacks WWAN connectivity support for the modem integrated
into the SoC.

Lacks, ok. Does it specify, that Shikra has internal modem? No. Which SKUs have it? Does it make sense to split configuration into two different machines (like it is done for QCM6490-IDP vs RB3 Gen2) or does it make sense to keep all of them enabled as a single machine entry?
Is the cellular modem supported by the published qdsp6sw firmware or does it require a separate firmware file, to be licenced from Qualcomm?

github-actions · 2026-07-02T13:51:34Z

Test run workflow

Test jobs for commit `2e15d74`

nodistro
Pass: 10 | Fail: 0 | Total: 10

qcom-distro_linux-qcom-6.18
Pass: 221 | Fail: 1 | Total: 252

qcom-distro
Pass: 253 | Fail: 0 | Total: 283

Viswanath Kraleti (vkraleti) · 2026-07-02T14:01:15Z

Which SKUs have it?

The CQM variant supports an integrated CAT4 cellular modem in addition to WLAN running on the Q6. The CQS variant supports Audio and WLAN on the Q6, but does not include cellular modem functionality.

Does it make sense to split configuration into two different machines (like it is done for QCM6490-IDP vs RB3 Gen2) or does it make sense to keep all of them enabled as a single machine entry?

Maintaining separate machine configurations does not provide much value as the there is no difference in the publicly available firmware between the CQM and CQS variants. Even the CDT is shared by these variants.

Is the cellular modem supported by the published qdsp6sw firmware or does it require a separate firmware file, to be licenced from Qualcomm?

The qdsp6sw firmware published in linux-firmware.git does not include support for the cellular modem. Cellular modem functionality requires an additional modem firmware package that is provided separately to licensed customers.

Dmitry Baryshkov (lumag) · 2026-07-02T16:28:04Z

Thanks! Now you can turn it into a nice commit message.

Ricardo Salveti (ricardosalveti) · 2026-07-02T22:30:45Z

Yeah, please fix the commit message, we do have variants which do have such "machine feature", it is just that we are using one board conf supporting multiple variants, which is fine.

The Shikra CQM variant includes an integrated LTE Cat 4 modem. To support WWAN connectivity on modem-enabled configurations, the userspace modem management stack (ModemManager) must be enabled. qcom-distro enables ModemManager only for machines advertising the 'phone' capability through MACHINE_FEATURES. The CQM and CQS variants share the same publicly available firmware and CDT, so maintaining separate machine definitions provides little value. Note: cellular modem functionality requires an additional modem firmware package provided separately to licensed customers. Signed-off-by: Mrigank Dembla <mdembla@qti.qualcomm.com>

Mrigank Dembla (mdembla-bit) · 2026-07-03T02:22:29Z

Thanks. I've pushed an updated commit message covering the CQM integrated modem support and the shared shikra-evk configuration.

Mrigank Dembla (mdembla-bit) requested review from Anuj Mittal (anujm1), Koen Kooi (koenkooi), Dmitry Baryshkov (lumag), Nicolas Dechesne (ndechesne), Ricardo Salveti (ricardosalveti) and Viswanath Kraleti (vkraleti) as code owners July 1, 2026 09:59

Dmitry Baryshkov (lumag) requested changes Jul 1, 2026

View reviewed changes

Mrigank Dembla (mdembla-bit) force-pushed the shikra-evk-phone-feature branch from 0a00e70 to b9b1863 Compare July 1, 2026 10:51

Mrigank Dembla (mdembla-bit) requested a review from Dmitry Baryshkov (lumag) July 1, 2026 10:53

Mrigank Dembla (mdembla-bit) force-pushed the shikra-evk-phone-feature branch from b9b1863 to 7e00ed5 Compare July 1, 2026 15:46

Dmitry Baryshkov (lumag) requested changes Jul 1, 2026

View reviewed changes

Mrigank Dembla (mdembla-bit) requested a review from Dmitry Baryshkov (lumag) July 2, 2026 04:11

Mrigank Dembla (mdembla-bit) force-pushed the shikra-evk-phone-feature branch from 7e00ed5 to 2e15d74 Compare July 2, 2026 11:02

Dmitry Baryshkov (lumag) requested changes Jul 2, 2026

View reviewed changes

Mrigank Dembla (mdembla-bit) force-pushed the shikra-evk-phone-feature branch from 2e15d74 to ed69165 Compare July 3, 2026 02:16

Mrigank Dembla (mdembla-bit) requested a review from Dmitry Baryshkov (lumag) July 3, 2026 02:22

Viswanath Kraleti (vkraleti) added the backport wrynose label Jul 3, 2026

Koen Kooi (koenkooi) approved these changes Jul 3, 2026

View reviewed changes

Dmitry Baryshkov (lumag) approved these changes Jul 3, 2026

View reviewed changes

Uh oh!

Conversation

Mrigank Dembla (mdembla-bit) commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dmitry Baryshkov (lumag) left a comment

Choose a reason for hiding this comment

Uh oh!

Mrigank Dembla (mdembla-bit) commented Jul 1, 2026

Uh oh!

Dmitry Baryshkov (lumag) commented Jul 1, 2026

Uh oh!

Mrigank Dembla (mdembla-bit) commented Jul 1, 2026

Uh oh!

Dmitry Baryshkov (lumag) left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 1, 2026

Test run workflow

Test jobs for commit 7e00ed5

Uh oh!

test-reporting-app Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Mrigank Dembla (mdembla-bit) commented Jul 2, 2026

Uh oh!

Dmitry Baryshkov (lumag) commented Jul 2, 2026

Uh oh!

Mrigank Dembla (mdembla-bit) commented Jul 2, 2026

Uh oh!

Dmitry Baryshkov (lumag) left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 2, 2026

Test run workflow

Test jobs for commit 2e15d74

Uh oh!

Viswanath Kraleti (vkraleti) commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dmitry Baryshkov (lumag) commented Jul 2, 2026

Uh oh!

Ricardo Salveti (ricardosalveti) commented Jul 2, 2026

Uh oh!

Mrigank Dembla (mdembla-bit) commented Jul 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Mrigank Dembla (mdembla-bit) commented Jul 1, 2026 •

edited

Loading

Test jobs for commit `7e00ed5`

test-reporting-app Bot commented Jul 1, 2026 •

edited

Loading

Test jobs for commit `2e15d74`

Viswanath Kraleti (vkraleti) commented Jul 2, 2026 •

edited

Loading