Include modem firmware placeholder in packagegroup-qcm6490-idp #2561
+46
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Specify location of the corresponding NON-HLOS.bin file by adding | ||
| # NHLOS_URI:pn-firmware-qcom-qcm6490-idp = "..." to local.conf. Use "file://" | ||
| # if the file is provided locally. | ||
|
|
||
| DESCRIPTION = "QCOM Firmware for QCM6490-IDP board" | ||
|
|
||
| LICENSE = "CLOSED" | ||
|
|
||
| FW_QCOM_NAME = "qcm6490" | ||
|
|
||
| FW_QCOM_LIST = "\ | ||
| modem.mbn \ | ||
| " | ||
|
|
||
| S = "${UNPACKDIR}" | ||
|
|
||
| require recipes-bsp/firmware/firmware-qcom.inc | ||
| require recipes-bsp/firmware/firmware-qcom-nhlos.inc | ||
|
|
||
| SPLIT_FIRMWARE_PACKAGES = "\ | ||
| linux-firmware-qcom-${FW_QCOM_NAME}-modem \ | ||
| " | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Specify location of the corresponding NON-HLOS.bin file by adding | ||
| # NHLOS_URI:pn-firmware-qcom-rb3gen2 = "..." to local.conf. Use "file://" | ||
| # if the file is provided locally. | ||
|
|
||
| DESCRIPTION = "QCOM Firmware for Rb3Gen2 board" | ||
|
|
||
|
|
||
| LICENSE = "CLOSED" | ||
|
|
||
| FW_QCOM_NAME = "qcs6490" | ||
|
|
||
| FW_QCOM_LIST = "\ | ||
| modem.mbn \ | ||
| " | ||
|
|
||
| S = "${UNPACKDIR}" | ||
|
|
||
| require recipes-bsp/firmware/firmware-qcom.inc | ||
| require recipes-bsp/firmware/firmware-qcom-nhlos.inc | ||
|
|
||
| SPLIT_FIRMWARE_PACKAGES = "\ | ||
| linux-firmware-qcom-${FW_QCOM_NAME}-modem \ | ||
| " | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to handle
modem_prfiles? I see them in the image for RB3 Gen2, but they are likely unsed there. My guess is that the IDP will use those files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dmitry Baryshkov (@lumag) I checked multiple NON_HLOS.bins available internally. None of the have
modem_prfiles. As I understand from Target team,modem_pris distributed as separate zip file. So I am not sure about the path to add here. If you can share an example binary, I'll update the paths accordingly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viswanath Kraleti (@vkraleti) From the Thundercomm SDK for RB3 Gen2: