-
Notifications
You must be signed in to change notification settings - Fork 303
Fix Yocto Project Compatibility requirements #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dmitry Baryshkov (lumag)
wants to merge
8
commits into
qualcomm-linux:wrynose
Choose a base branch
from
lumag:fix-mixin-deps
base: wrynose
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4cb8f66
hexagon-dsp-binaries: restore recipe matching OE-Core
lumag f828c3a
hexagon-dsp-binaries: disable if lts-linux-firmware-mixin is not enabled
lumag 40aeeb6
hexagon-dsp-binaries: create packages for QCM6490-IDP
lumag 16618d9
packagegroup-qcom-m2-firmware: make linux-firmware-ath12k-qcc2072 opt…
lumag 7790e5a
layer.conf: add dynamic handling for lts-linux-firmware-mixin
lumag 8986f37
linux-firmware: enable version from lts-linux-firmware-mixin
lumag 349197c
layer.conf: move lts-linux-firmware-mixin to recommended layers
lumag 1eeb829
ci: perform builds without lts-linux-firmware-mixin layer
lumag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/siemens/kas/master/kas/schema-kas.json | ||
|
|
||
| header: | ||
| version: 14 | ||
|
|
||
| distro: qcom-distro | ||
|
|
||
| defaults: | ||
| repos: | ||
| branch: wrynose | ||
|
|
||
| repos: | ||
| meta-qcom-distro: | ||
| url: https://github.com/qualcomm-linux/meta-qcom-distro | ||
|
|
||
| meta-openembedded: | ||
| url: https://github.com/openembedded/meta-openembedded | ||
| patches: | ||
| plain: | ||
| repo: meta-qcom | ||
| path: patches/meta-oe/0001-mariadb-fix-building-for-the-ARMv8.3-A-and-later-sys.patch | ||
| layers: | ||
| meta-filesystems: | ||
| meta-gnome: | ||
| meta-multimedia: | ||
| meta-networking: | ||
| meta-oe: | ||
| meta-python: | ||
| meta-xfce: | ||
|
|
||
| meta-virtualization: | ||
| url: https://git.yoctoproject.org/git/meta-virtualization | ||
|
|
||
| meta-audioreach: | ||
| url: https://github.com/AudioReach/meta-audioreach | ||
| branch: master | ||
|
|
||
| meta-selinux: | ||
| url: https://git.yoctoproject.org/meta-selinux | ||
|
|
||
| meta-updater: | ||
| url: https://github.com/uptane/meta-updater | ||
|
|
||
| meta-security: | ||
| url: https://git.yoctoproject.org/meta-security | ||
| layers: | ||
| .: | ||
| meta-tpm: | ||
|
|
||
| local_conf_header: | ||
| virtualization: | ||
| SKIP_META_VIRT_SANITY_CHECK = "1" | ||
|
|
||
| target: | ||
| - qcom-multimedia-image | ||
| - qcom-multimedia-proprietary-image | ||
| - qcom-container-orchestration-image | ||
| - qcom-networking-image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...s/lts-linux-firmware-mixin/recipes-kernel/linux-firmware/linux-firmware_20260519.bbappend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| DEFAULT_PREFERENCE:qcom = "1" |
41 changes: 41 additions & 0 deletions
41
...s-bsp/hexagon-dsp-binaries/hexagon-dsp-binaries/0001-conf-add-links-for-QCM6490-IDP.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| From 9957e017831ae90142ad2be4fc828a7160db7390 Mon Sep 17 00:00:00 2001 | ||
| From: Sairamreddy Bojja <sbojja@qti.qualcomm.com> | ||
| Date: Mon, 13 Apr 2026 12:41:13 +0530 | ||
| Subject: [PATCH] conf: add links for QCM6490 IDP | ||
|
|
||
| Add links for QCM6490 IDP platform based on RB3 Gen2. | ||
|
|
||
| Signed-off-by: Sairamreddy Bojja <sbojja@qti.qualcomm.com> | ||
| Upstream-Status: Backport [https://github.com/linux-msm/hexagon-dsp-binaries/commit/9957e017831ae90142ad2be4fc828a7160db7390] | ||
| --- | ||
| conf.d/hexagon-dsp-binaries-qualcomm-qcm6490-idp.yaml | 5 +++++ | ||
| config.txt | 4 ++++ | ||
| 2 files changed, 9 insertions(+) | ||
| create mode 100644 conf.d/hexagon-dsp-binaries-qualcomm-qcm6490-idp.yaml | ||
|
|
||
| diff --git a/conf.d/hexagon-dsp-binaries-qualcomm-qcm6490-idp.yaml b/conf.d/hexagon-dsp-binaries-qualcomm-qcm6490-idp.yaml | ||
| new file mode 100644 | ||
| index 000000000000..aa2a4123fe4b | ||
| --- /dev/null | ||
| +++ b/conf.d/hexagon-dsp-binaries-qualcomm-qcm6490-idp.yaml | ||
| @@ -0,0 +1,5 @@ | ||
| +# SPDX-License-Identifier: MIT | ||
| +# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | ||
| +machines: | ||
| + Qualcomm Technologies, Inc. QCM6490 IDP: | ||
| + DSP_LIBRARY_PATH: qcm6490/Qualcomm/QCM6490-IDP/dsp | ||
| diff --git a/config.txt b/config.txt | ||
| index a7640e4bf61f..8d3624dfc71c 100644 | ||
| --- a/config.txt | ||
| +++ b/config.txt | ||
| @@ -94,3 +94,7 @@ Link: sa8775p/Qualcomm/SA8775P-RIDE/dsp/gdsp1 sa8775p/Qualcomm/IQ9075-EVK/dsp/gd | ||
| Link: sa8775p/Qualcomm/SA8775P-RIDE/dsp/cdsp1 sa8775p/Qualcomm/IQ9075-EVK/dsp/cdsp1 | ||
| Link: sa8775p/Qualcomm/SA8775P-RIDE/dsp/gdsp0 sa8775p/Qualcomm/IQ9075-EVK/dsp/gdsp0 | ||
| Link: sa8775p/Qualcomm/SA8775P-RIDE/dsp/gdsp1 sa8775p/Qualcomm/IQ9075-EVK/dsp/gdsp1 | ||
| + | ||
| +# QCM6490 IDP | ||
| +Link: qcm6490/Thundercomm/RB3gen2/dsp/adsp qcm6490/Qualcomm/QCM6490-IDP/dsp/adsp | ||
| +Link: qcm6490/Thundercomm/RB3gen2/dsp/cdsp qcm6490/Qualcomm/QCM6490-IDP/dsp/cdsp | ||
| -- | ||
| 2.53.0 | ||
|
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really what we intend? This way we'll have to support two firmware versions, and the version qcom prefer will no longer be the one from the mixin layer.
With this change, you need to remove the meta-lts-mixins dependency in the
ci/yocto-check-layer.sh.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what we must support until meta-lts-mixins / firmware branch is enable and available on the autobuilder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the bbappend. If the layer is available, it will be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered that meta-lts-mixins may never be YP compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will introduce a lot of complexity. We will now support two distinct versions of linux-firmware. For example #2450, that patch the linux-firmare may won't work, and similar ones will have the same problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jose Quaresma (@quaresmajose) any other proposals? The worse case would be to drop the meta-qcom/wrynose from the autobuilder and from the YP compatibility program.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not possible. meta-qcom being YP compatible is a must have. and part of our 'product' definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which means that (per definition) we should depend only on YP-compatible layers. Until the required branch of the mixins layer is not marked as compatible, we can not depend on it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no other proposal or solution to this problem. I think we need to discuss this more broadly. Moving this discussion to #2457 is more appropriate in my opinion because we can get opinions from other YP maintainers.