shikra-evk: add initial changes for shikra-evk board#2450
Conversation
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
kas-container: Error: configuration file 'ci/shikra-evk.yml' not found
Doesn't build
Don't describe what the recipe is doing, but instead explain why the recipe is needed and what it is delivering (e.g. edk2-based firmware at what level of functionality and compatibility with other targets, etc). |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
The biggest problem is that there is no signle "shikra-evk" board. There are three different boards, each having a separate model, compats, etc.
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
The biggest problem is that there is no signle "shikra-evk" board. There are three different boards, each having a separate model, compats, etc.
Test Results 110 files + 38 657 suites +288 5h 38m 59s ⏱️ + 58m 22s Results for commit b4d2916. ± Comparison against base commit e4d25b5. This pull request removes 5 tests.♻️ This comment has been updated with latest results. |
|
A major concern here is that we don't have this board in our lab (lava or axiom/coral), so this can't be tested (and won't be maintained as tested), which is a major concern. |
Dmitry Baryshkov (@lumag) vivpuar Product team is expecting a single image that can be used on all 3 variants. If hexagon-dsp-binaries recipe produces all 3 packages, qcom-shikra-[cqs|cqm|iqs]-evk-cdsp (they may symlink to each other avoid firmware duplication) and all 3 pkgs are included in the image by default, is it acceptable? Do we still need 3 machine configs? |
Test team is working on adding Shikra boards to Lava. To speed up the enablement, can it be done in two phases? First phase, build in CI run manual boot test before merging the PRs. Second phase complete Lava test enablement. |
If it was my decision I would say "no". This encourages to cut corners in the future. It would also not be fair to Hamoa team who are waiting for LAVA testing. See #2349 |
Update SRCREV to pick up V0.8 tag. Changes since V0.5: v0.6: - Update qcom-next-fitimage.its for overlay of monaco-camx-el2.dtbo - Update qcom-next-fitimage.its for Hamoa EL2 by @LXQUALCOMM - Update qcom-next-fitimage.its for Lemans and Monaco boards - Update qcom-next-fitimage.its for Purwa EL2 by @LXQUALCOMM - Update qcom-next-fitimage.its for Lemans and Monaco upstream camera DTB overlay v0.7: - scripts: add build-dtb-image.sh, self-contained FIT DTB image builder co-located with metadata - Update bit definition for board-subtype - qcom-metadata: dts: add Shikra msm-id entries v0.8: - Update qcom-next-fitimage.its to add camera overlay for Hamoa EL2 - workflow: add a test workflow to build dtb.bin - build-dtb-image: optionally prune its based on kernel input - qcom-next-fitimage.its: Add CamX DTBO support for Hamoa and Purwa EVK - Add ITP board-id entry in qcom-metadata - Add Shikra CQM, CQS and IQS variant support Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
Shikra platform has multiple variants that share same soc but differ in board subtype. Without their compatible strings, the FIT image loader cannot match the correct DTB at boot. Add the compatible string 'qcom_shikracqm-itp', 'qcom_shikracqs-itp' and 'qcom_shikraiqs-itp' for the Shikra DTB to ensure correct DTB matching for the Shikra ITP boards. Also add compatible strings to include the imx577-camera overlay for the Shikra ITP boards. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
Add recipe to deliver edk2 based boot firmware for Shikra ITP board. This enables UEFI compatible boot flow and ensures integration with flat build targets. LIC_FILES_CHKSUM will refer LICENSE.qcom-2.txt from within the bootbinaries zip instead of fetching a standalone LICENSE.txt Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
The Shikra board requires a board-specific Configuration Data Table (CDT) to correctly initialize hardware parameters such as DDR and RF calibration data during early boot. Without the CDT, the bootloader may be unable to correctly configure the hardware, resulting in boot failures or incorrect hardware behavior. Add recipe to fetch CDT required for Shikra ITP Board. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
Add firmware and Hexagon DSP packages into image for the Shikra-EVK boards. 'linux-firmware-qcom-shikra-adreno' package is not provided by oe-core and 'packagegroup-shikra-evk' depends on the patch that brings the package which will only be applied if qcom machine is selected. COMPATIBLE_MACHINE can be dropped once the linux-firmware will upgrade to 202606+ Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
Define a new package with shikra-soc specific kernel modules. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
The Shikra EVK is a new Qualcomm development board that has no machine definition in meta-qcom. Without this, it is not possible to build a Yocto image targeting Shikra hardware, blocking any software bring-up or validation work on this platform. This is an initial bring-up configuration, not all features are validated to GA quality yet. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
Without a KAS configuration file, developers and CI systems have no standardized way to set up the correct layers, MACHINE and build configuration for Shikra-EVK. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
The Shikra-EVK machine configuration is new and not yet covered by CI. Without a build job for this target, regressions in the machine config, packagegroups or firmware recipes can go undetected until a developer manually attempts a build. Signed-off-by: Vivek Puar <vpuar@qti.qualcomm.com>
Ricardo Salveti (ricardosalveti)
left a comment
There was a problem hiding this comment.
Fine with the changes, but please only merge once validated manually by someone, and with the test validation results available in a comment here.
|
Below are the Test valiation result on this PR Shikra bins for both 6.18 & qcom-next kernel
|
6.18: qcs6490 bootup crash Kernel panic - not syncing (unrelated PR) |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Display FAIL
What does it mean? Why does it fail?
|
Yeah, please comment what we will do with the failures, and explain in more details about the failures. |
|
Display on IQS is not enabled yet, hence the failure. There is an approved exception for this. |
774c978
into
qualcomm-linux:master
|
Git push to origin failed for wrynose with exitcode 1 |
Adding below changes for shikra-evk Board:
NOTE: This Shikra target PR will be for sample engineering, it won't be of the GA quality as we will have for the other targets.