refpolicy-targeted: enable PipeWire system-service mode for Qualcomm#383
Open
rchiluka29 wants to merge 1 commit into
Open
refpolicy-targeted: enable PipeWire system-service mode for Qualcomm#383rchiluka29 wants to merge 1 commit into
rchiluka29 wants to merge 1 commit into
Conversation
| @@ -0,0 +1 @@ | |||
| POLICY_CUSTOM_BUILDOPT:qcom = "pipewire_system_service" | |||
Contributor
There was a problem hiding this comment.
Change :qcom to :qcom-distro.
Author
There was a problem hiding this comment.
Done. Changed :qcom to :qcom-distro
rchiluka29
force-pushed
the
pipewire/system-service
branch
from
acb6fea to
1d17bbf
Compare
Dmitry Baryshkov (lumag)
approved these changes
Jul 2, 2026
Dmitry Baryshkov (lumag)
requested changes
Jul 2, 2026
| @@ -0,0 +1 @@ | |||
| POLICY_CUSTOM_BUILDOPT:qcom-distro = "pipewire_system_service" | |||
Contributor
There was a problem hiding this comment.
Hmm, should it be :append:qcom-distro? If so, don't forget the leading whitespace
Author
There was a problem hiding this comment.
yes, this can be done for future proofing.
Changed accordingly.
rchiluka29
force-pushed
the
pipewire/system-service
branch
from
1d17bbf to
66514f2
Compare
Dmitry Baryshkov (lumag)
previously approved these changes
Jul 3, 2026
Contributor
|
The upstream PipeWire SELinux policy has been merged into refpolicy (SELinuxProject/refpolicy#1109). Set POLICY_CUSTOM_BUILDOPT to pipewire_system_service so that PipeWire runs as a system-wide daemon on Qualcomm embedded targets. Signed-off-by: Chiluka Rohith <rchiluka@qti.qualcomm.com>
rchiluka29
force-pushed
the
pipewire/system-service
branch
from
66514f2 to
bc3a100
Compare
Author
|
Reverted to direct assignment. The :append approach causes a leading space in POLICY_CUSTOM_BUILDOPT which breaks the make command CUSTOM_BUILDOPT= pipewire_system_service gets split into an empty variable and a make target, causing No rule to make target 'pipewire_system_service'. Direct assignment avoids this since POLICY_CUSTOM_BUILDOPT ?= "" is a weak default that gets cleanly replaced. Validated locally for CUSTOM_BUILDOPT=pipewire_system_service (no leading space) is passed correctly to make. |
Contributor
|
Please sort it out in meta-selinux. We can't be using assignments in bbappends since other appends might also need to extend the variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream PipeWire SELinux policy has been merged into refpolicy (SELinuxProject/refpolicy#1109).
Set POLICY_CUSTOM_BUILDOPT to pipewire_system_service so that PipeWire runs as a system-wide daemon on Qualcomm embedded targets.