Repository navigation
Release v2.1.0 - #151
Merged
Merged
Release v2.1.0#151
Conversation
Follow-up to #143, which freed ports 80/443 on `magebox global stop`. `Start` had its own daemon-starting path that skipped the plist version check, so it could load an outdated daemon; it now delegates to `EnsureRulesActive`, the single reconciler that installs, upgrades and kickstarts. `Stop` reported failure whenever port 80 was still busy after the daemon was unloaded, even though an unrelated local service is free to take the port — which is the whole point of releasing it. `stopVerdict` now fails only while MageBox's own daemon is still loaded. `Stop` also returns early when nothing is listening, so an already-stopped environment no longer prompts for a sudo password, and the unload path wires stdin and stderr so that prompt and any launchctl error are visible. Docs: document the sudo requirement in the command reference, correct the FAQ claim that no daily operation needs sudo, and note the macOS step in the testing matrix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Every MageOS 3.x entry advertised PHP 8.2 and omitted 8.5, while upstream mage-os/mageos-magento2 requires ~8.3 || ~8.4 || ~8.5 for 3.2.0 through 3.5.0. `magebox new` offers that list, so it steered people onto a PHP version the install cannot run on and hid a supported one. Add tests guarding the advertised versions against upstream drift and guarding the two copies of the registry against diverging. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the 2.1.0 release. The three merged contributions it covers (#148, #145, #143) are already on
main; this branch adds the follow-up work, the version bump and the changelog.What is in this branch
magebox global stop(#108) #143) — follow-up to the merged PR:Starthad a second daemon-starting path that skipped the plist version check, so it could load an outdated daemon. It now delegates toEnsureRulesActive, the single reconciler that installs, upgrades and kickstarts.Stopreported failure whenever port 80 was still busy after the daemon was unloaded, even though another local service taking the port is exactly what freeing it allows.stopVerdictnow fails only while MageBox's own daemon is still loaded.Stopreturns early when nothing is listening, so an already-stopped environment no longer prompts for a sudo password, and the unload path wires stdin and stderr so the prompt and any launchctl error are visible.mage-os/mageos-magento2requires~8.3 || ~8.4 || ~8.5for 3.2.0 through 3.5.0.magebox newoffers that list, so it steered people onto a PHP version the install cannot run on and hid a supported one. New tests guard the advertised versions against upstream drift and keep the embedded and shipped copies of the registry identical.VERSIONbump and the changelog entry, covering the two version registry PRs, the port-freeing feature and the MageOS autoload fix already onmain.Verification
make testgofmtThe port forwarding code paths are macOS-only and were verified by unit tests and review, not on a macOS machine.
After merging
Merging changes
VERSIONonmain, which fires the auto-tag workflow. Tags created by that workflow useGITHUB_TOKENand therefore do not trigger the release build, so the tag still has to be deleted and re-pushed from a local machine before binaries are built.🤖 Generated with Claude Code