Skip to content

refactor: add batch_size to qdrant __init__#38

Open
pandasar13 wants to merge 1 commit intoqdrant:masterfrom
pandasar13:qdrant_pr
Open

refactor: add batch_size to qdrant __init__#38
pandasar13 wants to merge 1 commit intoqdrant:masterfrom
pandasar13:qdrant_pr

Conversation

@pandasar13
Copy link
Copy Markdown

@pandasar13 pandasar13 commented Nov 23, 2023

Pull Request

Description

Add batch_size parameter to init. The batch_size parameter specified in the init of qdrant for the functions get_all_documents(), get_all_documents_generator(), get_documents_by_id(), write_documents() (NOT for update_embeddings) not only ensures that there is consistency with other haystack DocumentStores but also allows to specify the batch_size when initializing the DocumentStore which allows for the use of pipelines in a less constrained manner.

Related Issue

This PR is related to this issue #37

Changes Made

Added batch size to qdrant init method. The functionsget_all_documents(), get_all_documents_generator(), get_documents_by_id(), write_documents()will take the batch_size specified in the init if not specified.

Checklist

  • I have tested the changes locally.
  • I have addressed all the comments from the code review.
  • This pull request follows the coding style of the project.
  • I have assigned the PR to the correct milestone.

Additional Notes

[Add any additional information or context that might be relevant to reviewers.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant