Full Review - #5
Open
bitfield wants to merge 33 commits into
Open
Conversation
Get weather for Lat Lon
bitfield
commented
Nov 10, 2021
| @@ -0,0 +1,56 @@ | |||
|  | |||
Collaborator
Author
There was a problem hiding this comment.
These badges look nice!
|
|
||
| # meteo | ||
|
|
||
| Meteo is a Go client library for the weather and meteorological forecast from [Yr](https://www.yr.no/en). |
Collaborator
Author
There was a problem hiding this comment.
Great README! Maybe move the example up to the top, so it's the first thing users see?
| } | ||
| c, err := NewNorwayClient(resolver) | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, err) |
Collaborator
Author
There was a problem hiding this comment.
Printing to standard error makes sense!
|
|
||
| func TestCreateNewMeteoClient(t *testing.T) { | ||
| t.Parallel() | ||
| var c *meteo.NorwayClient |
Collaborator
Author
There was a problem hiding this comment.
This is a neat way to show the reader what NewNorwayClient returns.
| t.Parallel() | ||
| mux := http.NewServeMux() | ||
|
|
||
| mux.HandleFunc("/weatherapi/locationforecast/2.0/compact", func(rw http.ResponseWriter, r *http.Request) { |
Collaborator
Author
There was a problem hiding this comment.
Feels like this is testing a lot in one test!
A simpler test fixture might be easier to understand and there's less danger of bugs in the fixture.
Co-authored-by: John Arundel <john@bitfieldconsulting.com>
Co-authored-by: John Arundel <john@bitfieldconsulting.com>
Co-authored-by: John Arundel <john@bitfieldconsulting.com>
Co-authored-by: John Arundel <john@bitfieldconsulting.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full review of the entire repository. When this PR is complete, be sure to manually merge its head branch into the main branch for this repository.