calculating the mean of an orientation with respect to symmetry#669
Open
argerlt wants to merge 23 commits into
Open
calculating the mean of an orientation with respect to symmetry#669argerlt wants to merge 23 commits into
argerlt wants to merge 23 commits into
Conversation
Member
|
This is good, it's the same approach as taken in MTEX (I believe some call it the "flip-flop" algorithm). |
argerlt
force-pushed
the
symmetry_respecting_mean
branch
from
June 26, 2026 02:54
50ba623 to
07856cc
Compare
Collaborator
Author
|
pre-commit.ci autofix |
Collaborator
Author
|
Almost done, but the new failing test is a real error and I need to run some tests to see if #671 is the correct solution. |
argerlt
marked this pull request as draft
July 1, 2026 01:03
Collaborator
Author
|
Nevermind, heavily edited. |
argerlt
force-pushed
the
symmetry_respecting_mean
branch
from
July 2, 2026 22:43
a948f8e to
d4f7129
Compare
argerlt
force-pushed
the
symmetry_respecting_mean
branch
from
July 9, 2026 02:54
4c153ec to
181db7d
Compare
argerlt
force-pushed
the
symmetry_respecting_mean
branch
from
July 9, 2026 23:55
e1cc842 to
896bb8c
Compare
argerlt
force-pushed
the
symmetry_respecting_mean
branch
from
July 15, 2026 01:08
896bb8c to
a85ddda
Compare
Collaborator
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
argerlt
marked this pull request as ready for review
July 15, 2026 01:18
This was
linked to
issues
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Currently a draft, but this would be an up-to-date solution to #434 and #437EDIT: complete, ready for review. Description below also updated for clarity.
As originally discussed,
meanis calculated for transforms with symmetry using a variation of the 'flip-flop' method:In the process of this simple fix, it turned out ORIX had some inconsistent handling of fundamental zones and reduction. This update makes it match exactly with the original paper previously mentioned as the souce for OrientationRegion.from_symmetry.
Other things fixed along the way:
Orientation.dot_outerdiscussed inOrientation.dot_outer()scambles axis ordering and can give the wrong answer #673Progress of the PR
For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.