Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
big update, addressing missing attributes. For now:
|
|
Is this ready for review ? |
|
at least a first review, yes |
MatthieuDartiailh
left a comment
There was a problem hiding this comment.
I did not review the docs but the code part looks very neat. Much more consistent than before.
|
The documentation should be good now. And found a small bug in hislip event handling, and repaired a small type error. There are some issues that are not documented and do merit a second pair of eyes, especially since I cannot reliably test them in my lab: #638 (comment) Good to go for me, unless you want to address any of the mentioned issues (be it in compliance.rst or the comment referred just above) |
|
I will try to review during the week and merge. |
|
fyi, berg's tool says this: Still a nice number of bugs remaining..... |
|
Indeed... |
|
FYI: so that we don't set our requirement level too high: berg's script is pretty harsh. It hangs both my 34465A and DMM6500, via the NI-VISA backend. |
|
In the meantime, I've worked on some more things. See #638 Tell me if is OK to include in this PR. |
Started as a Very easy one. We might need to remove other exception logs, or lower them to debug.
Added loads of attributes, plus documentation of compliance.
pre-commitwith no errorsStill not great it throws a
VisaIOErrorinstead ofAttributeError, but that is inside PyVISA, not here.