Skip to content

remove exception logs and document compliance level - #645

Open
hb020 wants to merge 96 commits into
pyvisa:mainfrom
hb020:unknown_attribute
Open

hb020 wants to merge 96 commits into
pyvisa:mainfrom
hb020:unknown_attribute

Conversation

@hb020

@hb020 hb020 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Started as a Very easy one. We might need to remove other exception logs, or lower them to debug.

Added loads of attributes, plus documentation of compliance.

  • Closes Lower verbosity on unknown attribute #644
  • Executed pre-commit with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate. see below
  • Added an entry to the CHANGES file

Still not great it throws a VisaIOError instead of AttributeError, but that is inside PyVISA, not here.

@hb020

hb020 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

big update, addressing missing attributes. For now:

  • read coverage is better (but not full)
  • write coverage has been improved slightly

@MatthieuDartiailh

Copy link
Copy Markdown
Member

Is this ready for review ?

@hb020

hb020 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

at least a first review, yes

@MatthieuDartiailh MatthieuDartiailh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review the docs but the code part looks very neat. Much more consistent than before.

@hb020 hb020 changed the title remove exception logs remove exception logs and document compliance level Sep 12, 2026
@hb020

hb020 commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

The documentation should be good now.

And found a small bug in hislip event handling, and repaired a small type error.

There are some issues that are not documented and do merit a second pair of eyes, especially since I cannot reliably test them in my lab: #638 (comment)

Good to go for me, unless you want to address any of the mentioned issues (be it in compliance.rst or the comment referred just above)

@MatthieuDartiailh

Copy link
Copy Markdown
Member

I will try to review during the week and merge.

@hb020

hb020 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

fyi, berg's tool says this:
out.txt

Still a nice number of bugs remaining.....

@MatthieuDartiailh

Copy link
Copy Markdown
Member

Indeed...

@hb020

hb020 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

FYI: so that we don't set our requirement level too high: berg's script is pretty harsh. It hangs both my 34465A and DMM6500, via the NI-VISA backend.

@hb020

hb020 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

In the meantime, I've worked on some more things. See #638

Tell me if is OK to include in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lower verbosity on unknown attribute

2 participants