Refactor code for Sun zenith angle corrections and change to `effective_solar_pathlength_corrected` instead of `sunz_corrected` for built-in RGB recipes#3397

Open

strandgren wants to merge 49 commits into

pytroll:mainfrom

strandgren:refactor_solar_zenith_angle_correction_methods

Commits on May 21, 2026

Change tolerance given that the correction is now done in degrees instead of radians
strandgren
committed
Fix tests for SunZenithCorrector:
strandgren
committed
Add tests to verify that data are not computed and kept lazy
strandgren
committed
Remove keyword argument from test where it's not used
strandgren
committed
Fix typo and pass sunz angle as optional_dataset
strandgren
committed
Add missing tests for EffectiveSolarPathLengthCorrector
strandgren
committed
Add UserWarning tests for deprecated reduction parameters in EffectiveSolarPathLengthCorrector
strandgren
committed
Fix SunZenithReducer following refactoring work on SunZenithCorrectorBase
strandgren
committed
Fix SunZenithReducer tests to make sure that sunz_sza is passed and used as expected. Fix expected values to pass updated values of sunz_sza.
strandgren
committed
Remove unused arguments
strandgren
committed
Make sure sunzen_corr_cos doesn't compute any data and remove map_blocks wrapper
strandgren
committed
Add tests to check that data type is preserved in SunZenithReducer and that no computation is triggered.
strandgren
committed
Make sure sunzen_reduction doesn't compute any data and remove map_blocks wrapper
strandgren
committed
Refactor sunzen_corr_cos to reduce cyclomatic complexity,
strandgren
committed

Commits on May 22, 2026

Commits on May 26, 2026

Commits on May 27, 2026

Commits on May 28, 2026

Commits on Jun 3, 2026