Added readers for the new cloud base height (CBH) product and all day optical thickness (ADCOT) in PPS#3396
Merged
Merged
Conversation
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
==========================================
- Coverage 96.30% 96.30% -0.01%
==========================================
Files 466 466
Lines 59090 59088 -2
==========================================
- Hits 56908 56906 -2
Misses 2182 2182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The check that fails is not related to the changes in this pull request. |
Member
|
I have a fix for the unstable CI build in #3408 , so need to worry about it 👍 |
mraspaud
approved these changes
Jun 1, 2026
Member
mraspaud
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding these products. If you could add a picture or two to the conversation thread, that would be great.
Contributor
Author
Contributor
Author
pnuu
approved these changes
Jun 1, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR adds readers for new NWCSAF-PPS products: cloud base height/pressure/height_in _hectorfeet/temperature
AUTHORS.mdif not there already