Skip to content

Added readers for the new cloud base height (CBH) product and all day optical thickness (ADCOT) in PPS#3396

Merged
mraspaud merged 5 commits into
pytroll:mainfrom
ikaur17:main
Jun 1, 2026
Merged

Added readers for the new cloud base height (CBH) product and all day optical thickness (ADCOT) in PPS#3396
mraspaud merged 5 commits into
pytroll:mainfrom
ikaur17:main

Conversation

@ikaur17
Copy link
Copy Markdown
Contributor

@ikaur17 ikaur17 commented May 20, 2026

This PR adds readers for new NWCSAF-PPS products: cloud base height/pressure/height_in _hectorfeet/temperature

  • Fully documented
  • Add your name to AUTHORS.md if not there already

@ikaur17 ikaur17 marked this pull request as draft May 21, 2026 09:31
@ikaur17 ikaur17 changed the title Added readers for the new cloud base height product in PPS Added readers for the new cloud base height (CBH) product and all day optical thickness (ADCOT) in PPS May 26, 2026
@ikaur17
Copy link
Copy Markdown
Contributor Author

ikaur17 commented May 26, 2026

pre-commit.ci autofix

@ikaur17 ikaur17 marked this pull request as ready for review May 26, 2026 10:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.30%. Comparing base (18d7f60) to head (a246cc2).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3396      +/-   ##
==========================================
- Coverage   96.30%   96.30%   -0.01%     
==========================================
  Files         466      466              
  Lines       59090    59088       -2     
==========================================
- Hits        56908    56906       -2     
  Misses       2182     2182              
Flag Coverage Δ
behaviourtests 3.59% <ø> (+<0.01%) ⬆️
unittests 96.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ikaur17
Copy link
Copy Markdown
Contributor Author

ikaur17 commented Jun 1, 2026

The check that fails is not related to the changes in this pull request.

@pnuu
Copy link
Copy Markdown
Member

pnuu commented Jun 1, 2026

I have a fix for the unstable CI build in #3408 , so need to worry about it 👍

Copy link
Copy Markdown
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding these products. If you could add a picture or two to the conversation thread, that would be great.

@ikaur17
Copy link
Copy Markdown
Contributor Author

ikaur17 commented Jun 1, 2026

ADCOT resampled to region: OMERC_BB
S_NWC_ADCOT_noaa20_00000_20250301T1308398Z_20250301T1310043Z_adcot_omerc_bb

@ikaur17
Copy link
Copy Markdown
Contributor Author

ikaur17 commented Jun 1, 2026

Cloud base height in hectofeet (region: sve)

S_NWC_CBH_npp_00000_20250301T1243039Z_20250301T1244281Z_cbh_hfeet_sve

@ikaur17
Copy link
Copy Markdown
Contributor Author

ikaur17 commented Jun 1, 2026

Cloud base pressure (region : sve)

S_NWC_CBH_npp_00000_20250301T1243039Z_20250301T1244281Z_cbh_pres_sve

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers component:compositors labels Jun 1, 2026
@mraspaud mraspaud merged commit 6da6920 into pytroll:main Jun 1, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:compositors component:readers enhancement code enhancements, features, improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants