WMO Instruments Part 2.2: File Handlers#3393
Closed
sfinkens wants to merge 31 commits into
Closed
Conversation
…atpy into wmo-instruments-part1
Member
Author
|
Sorry, wrong target branch, correct one: sfinkens#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update all file handlers to provide WMO instrument names. To be merged into #3390. This is the biggest one.
Summary:
satpy._instruments.OSCAR).readers/*.yamlin favour of "instruments".and print deprecation warning.
readers/*.yaml: Renamed "sensors" to "instruments" in some files (case 2 below),saved the rest for another PR.
{"SeaWiFS", "MERIS", "MODIS", "VIIRS"}instead of "merged". Source: https://docs.pml.space/share/s/2RVhiuK2SWyhbSthqDDoxgto distinguish between 8-11 and 12-15.
Why not change all reader YAMLs? Because this would add too much complexity to this PR. Instrument names in
readers/*.yamlserves two purposes, again.Translating them to WMO names is not always straightforward, so I only changed to WMO names in case 2 and saved
case 1 for a future PR. In particular:
instrument_name: visir/<sensor>doesn't work anymore,because WMO names might contain slashes and parentheses ("AVHRR/2"). Needs a new "dependencies" attribute.
mersi-1.yaml->mersi1.yaml)but they all use the same composites/enhancements. So instead of copying the composites/enhancements we
decided to stick to just "MWR". But that's not a valid WMO name.
scatterometer,hsaf). The sole purposeof that attribute is to link composites/enhancements.
AUTHORS.mdif not there already