Skip to content

Next try with WMO sensor names#3382

Closed
sfinkens wants to merge 1 commit into
pytroll:mainfrom
sfinkens:instrument-serialization
Closed

Next try with WMO sensor names#3382
sfinkens wants to merge 1 commit into
pytroll:mainfrom
sfinkens:instrument-serialization

Conversation

@sfinkens
Copy link
Copy Markdown
Member

Here's a new try, where the sensor attribute holds a set of WMO names. The
attribute itself is not modified. I added normalization and serialization methods
to make use of this attribute in filenames.

We can't use it like this, because changing the type of the sensor attribute
would breaks users' workflows. The plan is to add a new instruments
attribute that can be used instead. But for now I just used sensor
to keep the number of changes small and see if that's the direction we
want to go.

As I was going through the code base I found it easier working with the set
most of the time. For YAML filenames (which only contain a single sensor)
I added a function to normalize the sensor name. Only in the Writer
class I needed a serialization function for multiple sensors.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@sfinkens
Copy link
Copy Markdown
Member Author

Grrr, I amended to an older commit, will fix this tomorrow, gotta go now

@djhoese
Copy link
Copy Markdown
Member

djhoese commented Apr 30, 2026

You might need to remake this PR. It has the NDVI Hybrid green change that I made and my commit message, but includes your other changes. Very confusing. Not sure how this happened.

Otherwise, I think the biggest/easiest change I'd like on this is to rename all the helper functions and variables to be "instrument" or "inst" (for the shorter variable names). That's what I took from the slack conversations is that we should do instruments everywhere and get away from sensor.

@sfinkens sfinkens force-pushed the instrument-serialization branch from 47460f7 to 78894c3 Compare May 4, 2026 11:52
@sfinkens
Copy link
Copy Markdown
Member Author

sfinkens commented May 4, 2026

Fixed the amended commit.

rename all the helper functions and variables to be "instrument"

Agreed! I didn't do that yet to make it easier to review. That's the next step once we're sure that this is the direction we want to go

@sfinkens
Copy link
Copy Markdown
Member Author

sfinkens commented May 6, 2026

Superseded by #3390

@sfinkens sfinkens closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants