[graph_trainer] Add MANIFESTO.md#3014
Merged
SherlockNoMad merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
MANIFESTO.md articulates why GraphTrainer exists: eager PyTorch cannot keep up with accelerator scaling, and distributed training at scale will require a compiler. Documents the eager challenges (composability, CUDAGraph complexity, coarse scheduling) and GraphTrainer's bets (single unified graph, everything as graph passes, SimpleFSDP, debuggability). ARCHITECTURE.md is a skeleton pointing to the manifesto, README, and developer guide — content to follow.
SherlockNoMad
requested review from
aditvenk,
tianyu-l,
xmfan and
yiming0416
as code owners
meta-cla
Bot
added
the
CLA Signed
Will be added in a follow-up once content is ready.
SherlockNoMad
changed the title
aditvenk
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MANIFESTO.mdarticulating why GraphTrainer exists: eager PyTorch cannot keep up with accelerator scaling, and distributed training at scale will require a compilerTest plan