Add MLX op handler for aten.trunc#18985
Closed
Jah-yee wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
Add a decomposed handler for aten.trunc that uses existing MLX nodes (floor, ceil, where, greater_equal) to implement truncation toward zero on Metal GPU. Fixes: pytorch#18923
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18985
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
Author
|
Closing as duplicate - trunc handler already covered in PR #18982. |
nil-is-all
added
the
module: mlx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
This PR adds support for
aten.truncin the MLX delegate backend, addressing issue #18923.Summary
Add a decomposed handler for
aten.truncthat uses existing MLX nodes (floor, ceil, where) to implement truncation toward zero on Metal GPU.Changes
_trunc_handlerinbackends/mlx/ops.pyusing the decomposition:trunc(x) = where(x >= 0, floor(x), ceil(x))Testing
References
aten.trunc#18923Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
RoomWithOutRoof
cc @metascroy