Skip to content

Improve RemovePermutesAroundElementwiseOps robustness (#18980)#18980

Merged
meta-codesync[bot] merged 1 commit intomainfrom
export-D101430531
Apr 20, 2026
Merged

Improve RemovePermutesAroundElementwiseOps robustness (#18980)#18980
meta-codesync[bot] merged 1 commit intomainfrom
export-D101430531

Conversation

@mcremon-meta
Copy link
Copy Markdown
Contributor

@mcremon-meta mcremon-meta commented Apr 17, 2026

Summary:

Improve the RemovePermutesAroundElementwiseOps pass with several
defensive enhancements:

  1. Add output node boundary check: reject subgraphs where a permutable
    op feeds directly into the graph output, since removing permutes
    would silently change the output format.

  2. Add constant input handling: when a subgraph boundary is a
    compile-time constant (parameter, buffer, get_attr, or ops computed
    entirely from constants), insert a compensating permute/view on it
    instead of rejecting the subgraph. This is free since it gets
    constant-folded.

  3. Add clamp.default to the set of permutable ops.

  4. Handle rank-mismatch for constant inputs (e.g. rank-1 bias with
    rank-4 permute) by using view_copy with appropriate shape reordering.

Reviewed By: DrJessop

Differential Revision: D101430531

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 17, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18980

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 4e8cd57 with merge base 063f9c9 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 17, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101430531.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot changed the title Improve RemovePermutesAroundElementwiseOps robustness Improve RemovePermutesAroundElementwiseOps robustness (#18980) Apr 18, 2026
meta-codesync Bot pushed a commit that referenced this pull request Apr 18, 2026
Summary:

Improve the RemovePermutesAroundElementwiseOps pass with several
defensive enhancements:

1. Add output node boundary check: reject subgraphs where a permutable
   op feeds directly into the graph output, since removing permutes
   would silently change the output format.

2. Add constant input handling: when a subgraph boundary is a
   compile-time constant (parameter, buffer, get_attr, or ops computed
   entirely from constants), insert a compensating permute/view on it
   instead of rejecting the subgraph. This is free since it gets
   constant-folded.

3. Add clamp.default to the set of permutable ops.

4. Handle rank-mismatch for constant inputs (e.g. rank-1 bias with
   rank-4 permute) by using view_copy with appropriate shape reordering.

Reviewed By: DrJessop

Differential Revision: D101430531
@meta-codesync meta-codesync Bot force-pushed the export-D101430531 branch from 39e6447 to 931fdc3 Compare April 18, 2026 00:27
meta-codesync Bot pushed a commit that referenced this pull request Apr 18, 2026
Summary:

Improve the RemovePermutesAroundElementwiseOps pass with several
defensive enhancements:

1. Add output node boundary check: reject subgraphs where a permutable
   op feeds directly into the graph output, since removing permutes
   would silently change the output format.

2. Add constant input handling: when a subgraph boundary is a
   compile-time constant (parameter, buffer, get_attr, or ops computed
   entirely from constants), insert a compensating permute/view on it
   instead of rejecting the subgraph. This is free since it gets
   constant-folded.

3. Add clamp.default to the set of permutable ops.

4. Handle rank-mismatch for constant inputs (e.g. rank-1 bias with
   rank-4 permute) by using view_copy with appropriate shape reordering.

Reviewed By: DrJessop

Differential Revision: D101430531
@meta-codesync meta-codesync Bot force-pushed the export-D101430531 branch from 931fdc3 to dca1584 Compare April 18, 2026 00:42
mcremon-meta added a commit that referenced this pull request Apr 20, 2026
Summary:
Pull Request resolved: #18980

Improve the RemovePermutesAroundElementwiseOps pass with several
defensive enhancements:

1. Add output node boundary check: reject subgraphs where a permutable
   op feeds directly into the graph output, since removing permutes
   would silently change the output format.

2. Add constant input handling: when a subgraph boundary is a
   compile-time constant (parameter, buffer, get_attr, or ops computed
   entirely from constants), insert a compensating permute/view on it
   instead of rejecting the subgraph. This is free since it gets
   constant-folded.

3. Add clamp.default to the set of permutable ops.

4. Handle rank-mismatch for constant inputs (e.g. rank-1 bias with
   rank-4 permute) by using view_copy with appropriate shape reordering.

Reviewed By: DrJessop

Differential Revision: D101430531
Summary:
Pull Request resolved: #18980

Improve the RemovePermutesAroundElementwiseOps pass with several
defensive enhancements:

1. Add output node boundary check: reject subgraphs where a permutable
   op feeds directly into the graph output, since removing permutes
   would silently change the output format.

2. Add constant input handling: when a subgraph boundary is a
   compile-time constant (parameter, buffer, get_attr, or ops computed
   entirely from constants), insert a compensating permute/view on it
   instead of rejecting the subgraph. This is free since it gets
   constant-folded.

3. Add clamp.default to the set of permutable ops.

4. Handle rank-mismatch for constant inputs (e.g. rank-1 bias with
   rank-4 permute) by using view_copy with appropriate shape reordering.

Reviewed By: DrJessop

Differential Revision: D101430531
@meta-codesync meta-codesync Bot merged commit c391738 into main Apr 20, 2026
167 of 170 checks passed
@meta-codesync meta-codesync Bot deleted the export-D101430531 branch April 20, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants