Skip to content

gh-148200: fix warning on missing safe memzero() on CYGWIN #148202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlo-bramini wants to merge 3 commits into
base: main
Choose a base branch
from
+23 −11
Open

gh-148200: fix warning on missing safe memzero() on CYGWIN #148202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
008a3a1
gh-148200: fix warning on missing safe memzero() on CYGWIN
carlo-bramini Apr 7, 2026
5bba02f
Merge branch 'python:main' into fix-cygwin-warning-2
carlo-bramini Apr 10, 2026
97d748a
gh-148200: sync HACL to the updated upstream
carlo-bramini Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Misc/sbom.spdx.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Modules/_hacl/Lib_Memzero0.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include <string.h>
#endif

#if defined(__FreeBSD__) || defined(__NetBSD__)
#if defined(__CYGWIN__) || defined(__FreeBSD__) || defined(__NetBSD__)
#include <strings.h>
#endif

Expand All @@ -57,7 +57,7 @@ void Lib_Memzero0_memzero0(void *dst, uint64_t len) {
SecureZeroMemory(dst, len_);
#elif defined(__APPLE__) && defined(__MACH__) && defined(APPLE_HAS_MEMSET_S)
memset_s(dst, len_, 0, len_);
#elif (defined(__linux__) && !defined(LINUX_NO_EXPLICIT_BZERO)) || defined(__FreeBSD__) || defined(__OpenBSD__)
#elif (defined(__linux__) && !defined(LINUX_NO_EXPLICIT_BZERO)) || defined(__CYGWIN__) || defined(__FreeBSD__) || defined(__OpenBSD__)
explicit_bzero(dst, len_);
#elif defined(__NetBSD__)
explicit_memset(dst, 0, len_);
Expand Down
12 changes: 12 additions & 0 deletions Modules/_hacl/libintvector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,18 @@ vector128 Lib_IntVector_Intrinsics_vec128_xor(vector128 x0, vector128 x1) {
#if defined(HACL_CAN_COMPILE_VEC128)

#include <altivec.h>

/* GCC's AltiVec extension hijacks 'bool' as '__vector __bool int'.
Restore C99/C11 scalar bool for HACL* code. */
#if defined(__GNUC__) && !defined(__clang__)
#undef bool
#define bool _Bool
#undef true
#define true 1
#undef false
#define false 0
#endif

#include <string.h> // for memcpy
#include <stdint.h>

Expand Down
2 changes: 1 addition & 1 deletion Modules/_hacl/refresh.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ fi

# Update this when updating to a new version after verifying that the changes
# the update brings in are good.
expected_hacl_star_rev=8ba599b2f6c9701b3dc961db895b0856a2210f76
expected_hacl_star_rev=504c2987452f87fe44bce9b9f12e19d6e051761f

hacl_dir="$(realpath "$1")"
cd "$(dirname "$0")"
Expand Down
Loading