gh-142927: Add scrollbar support to Tachyon HTML dark mode#148118
gh-142927: Add scrollbar support to Tachyon HTML dark mode#148118Wulian233 wants to merge 2 commits intopython:mainfrom
Conversation
|
These also apply to light mode, should they? And also But more importantly, this may override the user's OS scrollbar settings, which they may have customised for accessibility. Forcing them smaller and darker might mean it's hard for some to control or see. |
|
I adjusted the scope and now only add it where needed
This has been reused according to the existing heatmap design standards, so they should not have much impact:) cpython/Lib/profiling/sampling/_heatmap_assets/heatmap.css Lines 815 to 827 in 1f36a51 |
|
@hugovk @pablogsal May I ask if there are any further changes I need? |
|
@hugovk I am good with this PR but I will give you a couple of days before merging in case you have further comments. |
|
I don't think we should change the scrollbars, it makes the colour contrast worse and can be harder to use for those who need it. I don't think the original grey looks bad either. |
@hugovk
For compatibility, both approaches must be retained here.
::-webkit-scrollbaroffers the widest compatibility, but requires fully customizing the scrollbar.https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Selectors/::-webkit-scrollbar#browser_compatibility
scrollbar-coloris the newer standard, allowing us to style scrollbars without full customization. However, it is not supported by browsers from several years ago.https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/scrollbar-color#browser_compatibility
