chore: use pytest's new strict mode and fix duplicate tests#932
Merged
radoering merged 1 commit intopython-poetry:mainfrom Apr 19, 2026
Merged
chore: use pytest's new strict mode and fix duplicate tests#932radoering merged 1 commit intopython-poetry:mainfrom
radoering merged 1 commit intopython-poetry:mainfrom
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The pytest configuration in pyproject.toml should likely use the
[tool.pytest.ini_options]table (e.g.strict = trueunder that section) rather than[tool.pytest], otherwise the new strict setting may be ignored by pytest.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The pytest configuration in pyproject.toml should likely use the `[tool.pytest.ini_options]` table (e.g. `strict = true` under that section) rather than `[tool.pytest]`, otherwise the new strict setting may be ignored by pytest.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
1f401b5 to
a964a9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.