Remove redundant copy in getSequenceInRange#1385
Closed
nh13 wants to merge 1 commit into
Closed
Conversation
nh13
changed the title
nh13
force-pushed
the
nh13/fix-sequence-range-copy
branch
from
a8d3cbb to
028f834
Compare
Member
|
Thanks. Removing this silly mistake does make an observable difference to the speed. However we can do better — now also superseded by PR #1411. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSequenceInRangewherecharptr_to_bytes(seq)was called onseqwhich is already a Pythonbytesobject created byPyBytes_FromStringAndSizecharptr_to_bytescall was convertingbytes → const char* → bytes, creating an unnecessary copyTest plan
REF_PATH=: pytest tests/AlignedSegment_test.py -vAI disclosure: This PR was AI-assisted using Claude Code. The issue was identified via AI-guided code review, and the implementation was drafted by AI with human review and approval.