Conversation
Signed-off-by: William Woodruff <william@astral.sh>
Signed-off-by: William Woodruff <william@astral.sh>
Merged
Member
Author
|
#1310 will unblock the CI here. |
| # | ||
| # See: <https://github.com/pypa/twine/issues/1304> | ||
| # See: <https://github.com/pypi/warehouse/issues/19713> | ||
| status_phrase = "Unknown Status" |
Member
There was a problem hiding this comment.
Why not use response.reason since we get that from the server? Why explicitly call it unknown?
Member
Author
There was a problem hiding this comment.
Why not use
response.reasonsince we get that from the server? Why explicitly call it unknown?
We actually use both -- the render has the status code, phrase, and the reason. I can make that more explicit in the unit test as well, right now the reason message is invariant despite the parametrization.
(We could drop the status_phrase entirely in this case too, although that makes the diff slightly bigger for conditional rendering. Happy to change to that though.)
Signed-off-by: William Woodruff <william@astral.sh>
sigmavirus24
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1304 by turning the uncaught exception into a graceful error message and exit instead. For example, a user will now see something like:
...instead of a stack trace.
I'll also add a test for this.Done.Closes #1304.