Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 95.24% 95.62% +0.38%
==========================================
Files 22 23 +1
Lines 1829 1897 +68
Branches 343 357 +14
==========================================
+ Hits 1742 1814 +72
+ Misses 48 46 -2
+ Partials 39 37 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't know why codecov is generating so much noise in the timeline; I'm not doing anything except pushing commits. It wasn't doing this last week. |
I moved the token in an environment as recommended by zizmor but this is now failing on PR. I need to check how to silence this. Sorry for the noise. |
|
This PR is ready for review. |
|
thanks @mhsmith Given the size and scope of the PR it might take a bit of time to review properly. One thing that comes to mind not digging deeply into this is: |
|
Yes, in fact my desktop machine uses macOS, so I used it for almost all of my testing. I guess this means we should add a CI job for that platform as well, but I'll wait for your review before I deal with that. |
This will be used by cibuildwheel to replace its limited built-in support for adding external libraries to an Android wheel.
This involves cross-compilation, but it doesn't have much of an overlap with #512. It adds the
--ldpathsoption, which allows auditwheel to search an arbitrary sysroot, rather than the build machine's own libraries.