Skip to content

Add Android support#643

Open
mhsmith wants to merge 24 commits intopypa:mainfrom
mhsmith:android
Open

Add Android support#643
mhsmith wants to merge 24 commits intopypa:mainfrom
mhsmith:android

Conversation

@mhsmith
Copy link
Copy Markdown
Member

@mhsmith mhsmith commented Dec 13, 2025

This will be used by cibuildwheel to replace its limited built-in support for adding external libraries to an Android wheel.

This involves cross-compilation, but it doesn't have much of an overlap with #512. It adds the --ldpaths option, which allows auditwheel to search an arbitrary sysroot, rather than the build machine's own libraries.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.62%. Comparing base (d5801df) to head (e0bf5ba).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   95.24%   95.62%   +0.38%     
==========================================
  Files          22       23       +1     
  Lines        1829     1897      +68     
  Branches      343      357      +14     
==========================================
+ Hits         1742     1814      +72     
+ Misses         48       46       -2     
+ Partials       39       37       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mhsmith
Copy link
Copy Markdown
Member Author

mhsmith commented Mar 15, 2026

I don't know why codecov is generating so much noise in the timeline; I'm not doing anything except pushing commits. It wasn't doing this last week.

@mayeut
Copy link
Copy Markdown
Member

mayeut commented Mar 16, 2026

I don't know why codecov is generating so much noise in the timeline; I'm not doing anything except pushing commits. It wasn't doing this last week.

I moved the token in an environment as recommended by zizmor but this is now failing on PR. I need to check how to silence this. Sorry for the noise.

@mhsmith mhsmith marked this pull request as ready for review March 16, 2026 22:53
@mhsmith
Copy link
Copy Markdown
Member Author

mhsmith commented Mar 16, 2026

This PR is ready for review.

@mayeut
Copy link
Copy Markdown
Member

mayeut commented Mar 28, 2026

thanks @mhsmith

Given the size and scope of the PR it might take a bit of time to review properly.

One thing that comes to mind not digging deeply into this is:
cibuildwheel allows cross-building Android wheels from Linux or macOS if I'm not mistaken, so auditwheel probably needs to work on macOS for that use-case and thus be tested on macOS. I'm not sure how it would affect what's already done here but probably worth checking before a thorough review.

@mhsmith
Copy link
Copy Markdown
Member Author

mhsmith commented Mar 31, 2026

Yes, in fact my desktop machine uses macOS, so I used it for almost all of my testing. I guess this means we should add a CI job for that platform as well, but I'll wait for your review before I deal with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants