-
Notifications
You must be signed in to change notification settings - Fork 57
Add web search request pricing support #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kludex
wants to merge
5
commits into
main
Choose a base branch
from
add-web-search-request-pricing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c0750d6
Add web search request pricing support
Kludex 620f03e
Add file search request pricing and OpenRouter web search mapping
Kludex 69b7f1b
Refactor tool pricing to generic dict-based `tool_use_kcount` / `tool…
Kludex 3fb9843
Add audio_minutes, characters, images, video_seconds to ToolUseUnit
Kludex 22f44c2
Remove ToolUseUnit Literal - make tool use units arbitrary strings
Kludex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Pre-existing date mismatch between JS dataset test and Python dataset generation
The JS dataset test at
packages/js/src/__tests__/dataset.test.ts:89usesnew Date(2025, 11, 6, 12, 0, 0)which is December 6, 2025 in local time (JS months are 0-indexed). The Python dataset generation attests/dataset/extract_usages.py:115usesdatetime.datetime(2025, 11, 6, 12, 0, 0, tzinfo=datetime.timezone.utc)which is November 6, 2025 in UTC.This is a pre-existing discrepancy (not introduced by this PR). It doesn't currently cause test failures because all date-sensitive price constraints (like the
o3model's start_date of 2025-06-10) resolve to the same price tier for both dates. However, if a future price change has a start_date between November and December 2025, the JS and Python tests would compute different prices for the same dataset row.Was this helpful? React with 👍 or 👎 to provide feedback.