ParsedPrivateKey/ParsedPublicKey enums in key parsing#14593
Merged
Conversation
alex
reviewed
Apr 7, 2026
| let pkey = parsers.iter().find_map(|parser| match parser(data) { | ||
| let parsed = parsers.iter().find_map(|parser| match parser(data) { | ||
| Ok(key) => Some(Ok(key)), | ||
| // Try next parser |
Member
There was a problem hiding this comment.
Why are you removing these comments?
| } | ||
|
|
||
| pub type KeyParsingResult<T> = Result<T, KeyParsingError>; | ||
| pub type PrivateKeyParser = fn(&[u8]) -> KeyParsingResult<ParsedPrivateKey>; |
Member
There was a problem hiding this comment.
It doesn't make much sense to export this type alias here, it's just a random function signature.
Contributor
Author
There was a problem hiding this comment.
Moved to keys.rs as an inline type (but that's required as a separate type because clippy complains otherwise).
alex
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key parsing functions currently return
openssl::pkey::PKey directly, which assumes all parsed keys can be represented as an OpenSSL EVP_PKEY.This does not hold for ML-KEM, where the 64-byte seed is required for serialization but cannot be recovered from the EVP_PKEY. AWS-LC's
kem_priv_encodewrites the expanded secret key (2400 bytes) into PKCS#8 - not the seed. Whilekem_priv_decodecan read both the seed and expanded key formats, the seed is lost after key generation and cannot be extracted back from the PKey.Add
ParsedPrivateKeyandParsedPublicKeyenums with a single Pkey variant for now.