Add ML-DSA-44 support alongside existing ML-DSA-65#14591
Merged
reaperhulk merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
alex
force-pushed
the
claude/extend-ml-dsa-44-CHDFB
branch
3 times, most recently
from
f2f495f to
8a18d58
Compare
reaperhulk
reviewed
Apr 7, 2026
| >>> from cryptography.hazmat.primitives.asymmetric.mldsa import MlDsa65PrivateKey | ||
| >>> private_key = MlDsa65PrivateKey.generate() | ||
| >>> from cryptography.hazmat.primitives.asymmetric.mldsa import MlDsa44PrivateKey | ||
| >>> private_key = MlDsa44PrivateKey.generate() |
Member
There was a problem hiding this comment.
We should leave this 65 for the primary examples.
alex
force-pushed
the
claude/extend-ml-dsa-44-CHDFB
branch
from
8a18d58 to
9fd13af
Compare
reaperhulk
reviewed
Apr 7, 2026
| from cryptography.utils import Buffer | ||
|
|
||
|
|
||
| class MlDsa44PublicKey(metaclass=abc.ABCMeta): |
Member
There was a problem hiding this comment.
I know we already did this for 65, but do we want to use this casing for the Python APIs? Historically we've (at least mostly) done all caps for initialisms (e.g., SECP256R1) for the Python side.
Member
Author
There was a problem hiding this comment.
Ugh, no, we don't. Follow up PR though?
Member
Author
There was a problem hiding this comment.
#14596 (claude will rebase this once that merges)
Member
|
This needs a rebase |
alex
force-pushed
the
claude/extend-ml-dsa-44-CHDFB
branch
from
9fd13af to
9290822
Compare
reaperhulk
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MlDsaVariantenum patternMlDsaVariant::MlDsa44with NID, 1312-byte public key, 2420-byte signature,ml_dsa_44_sign/ml_dsa_44_verifyFFI2.16.840.1.101.3.4.3.17, PKCS#8/SPKI parsing viaMlDsaVariant::from_pkeydispatchMlDsa44PrivateKey/MlDsa44PublicKeywithgenerate_mldsa44_key,from_mldsa44_seed_bytes,from_mldsa44_public_bytesML_DSA_VARIANTStest list, KAT vectors, and wycheproof testsTest plan
https://claude.ai/code/session_01GaM5UZrNWJvnptDHvFNBWg