Conversation
facutuesca
force-pushed
the
dm/mldsa-docs
branch
from
9cd0dd8 to
d10c8cf
Compare
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
facutuesca
force-pushed
the
dm/mldsa-docs
branch
from
d10c8cf to
6a8da48
Compare
alex
reviewed
Mar 31, 2026
Member
alex
left a comment
alex
left a comment
There was a problem hiding this comment.
Mostly looks good. We should also add a changelog entry!
| rsa | ||
| dh | ||
| dsa | ||
| mldsa |
Member
There was a problem hiding this comment.
Let's organize this up at the top, no reason not to put PQC first!
| @@ -0,0 +1,231 @@ | |||
| .. hazmat:: | |||
|
|
|||
| ML-DSA-65 signing | |||
Member
There was a problem hiding this comment.
We should probably just title his ML-DSA Signing, as I assume we're going to follow up with other lengths shortly :-)
docs/conf.py
Outdated
Comment on lines
+54
to
+55
| from cryptography.hazmat.bindings._rust import openssl as _rust_openssl | ||
| SKIP_MLDSA = not _rust_openssl.CRYPTOGRAPHY_IS_AWSLC |
Member
There was a problem hiding this comment.
Isn't there a method on backend we can use?
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
facutuesca
force-pushed
the
dm/mldsa-docs
branch
from
91d2990 to
489dd56
Compare
alex
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14404, adds the docs for the new ML-DSA-65 implementation.
Since CI runs doctests only with OpenSSL, I've conditionally disabled them for these ML-DSA-65 docs. Should we add a new CI job for doctests with AWS-LC?
(Part of #14337)