BUG: Fix IndexError on empty string in ArrayObject._to_lst#3784
Open
Abzaek wants to merge 1 commit into
Open
Conversation
lst[0] raises IndexError when lst is the empty string ''.
Replace with lst.startswith('/') which returns False for '',
falling through to TextStringObject('') as expected.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3784 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 55 55
Lines 10291 10291
Branches 1890 1890
=======================================
Hits 10049 10049
Misses 137 137
Partials 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefan6419846
requested changes
May 18, 2026
Collaborator
stefan6419846
left a comment
stefan6419846
left a comment
There was a problem hiding this comment.
Thanks for the PR. Is there are real-world example where this could be observed?
Additionally, please provide a corresponding test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ArrayObject._to_lst()testedlst[0] == "/"to decide whether to create aNameObjectorTextStringObject. Whenlstis the empty string"", this raisesIndexError: string index out of range.This crashes
arr + "",arr += "", andarr -= "".Fix
Replace
lst[0] == "/"withlst.startswith("/")."".startswith("/")returnsFalse, falling through toTextStringObject("")as expected. Behavior is identical for all non-empty strings.