-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ENH: Check whether image is displayed on a given page #3738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreasntr
wants to merge
39
commits into
py-pdf:main
Choose a base branch
from
andreasntr:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
57390d1
add is_displayed_on_page function with caching
andreasntr ff16713
remove unneeded castings
andreasntr cf232f9
comply with linter
andreasntr 4d1ca4e
comply with linter
andreasntr 672ad47
remove example
andreasntr 069d5c5
add minimal test
andreasntr ff80e2e
comply with linter
andreasntr dd2ac2e
fix docstring and pdf path in test_is_xobject_image_displayed, add py…
andreasntr 27fc2bb
switch from page_number to page as is_displayed_on_page input
andreasntr 5f59487
temporarily remove is_displayed_on_page caching
andreasntr a09a6bb
Merge branch 'main' into main
andreasntr 58c75a6
switch display check to image constructor
andreasntr 2966ee2
fix tests to use the new is_displayed property
andreasntr 3bcf9a5
Merge branch 'main' into main
andreasntr 14a56d7
move image displayed check to page initialization
andreasntr e7f78cf
update references to _parse_images_from_content_stream
andreasntr b2a6114
Merge branch 'main' into main
andreasntr f0de97d
fix conflict with main
andreasntr 6cad13a
Merge branch 'main' into main
andreasntr 69cb462
Merge branch 'main' into main
andreasntr 54d6dd2
update sample files
andreasntr 6db1389
add _displayed_images test file
andreasntr f0c7a72
make _displayed_images private, deprecate inline_images and derive it…
andreasntr 18ebf94
update _displayed_images references
andreasntr 983022f
update inline_images references
andreasntr d6b7ff4
update some image paths
andreasntr 973f345
Merge branch 'main' into main
andreasntr 6f0aa8b
Update tests/test_images.py
andreasntr 183e10f
rename _displayed_images to _content_stream_images
andreasntr ccf4a9d
remove wrong docstring
andreasntr 42c1f81
add deprecation notice to inline_images setter
andreasntr 364ccbf
remove unneeded cache setter
andreasntr 683d5d4
use regular mock instead of type
andreasntr 70963f6
remove unneeded cache setter
andreasntr 439fab3
fix key error message in test_get_inline_image_without_xobject_resour…
andreasntr e4ea241
invalidate cache after manipulating images
andreasntr 38eebdb
emit warnings for image read errors instead of crashing
andreasntr bb11c8c
remove abbreviations
andreasntr 00411b1
Merge branch 'main' into main
andreasntr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.