ENH: Add actions base class#3552
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3552 +/- ##
==========================================
+ Coverage 97.68% 97.70% +0.01%
==========================================
Files 55 57 +2
Lines 10365 10454 +89
Branches 1913 1929 +16
==========================================
+ Hits 10125 10214 +89
Misses 134 134
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@stefan6419846 ready for code review. The code coverage is picking up comments, I don't know if this is a real code coverage issue or not. |
|
Could you please have a look at the style failures and the coverage first? |
Yes will try and fix the style failures. The coverage seems ok, and is even hightlighting comments. |
Invalid trigger values are not covered correctly. Additionally, rebasing the code on the lastest main might help as the comment indicates that your branch is 42 commits behind, possibly leading to unexpected results. |
Implement the JavaScript action at page-level.
j-t-1
left a comment
There was a problem hiding this comment.
@stefan6419846 change str to TriggerType everywhere?
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
j-t-1
left a comment
There was a problem hiding this comment.
Thanks @stefan6419846.
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
j-t-1
left a comment
There was a problem hiding this comment.
Thanks for your help @stefan6419846.
Implement the JavaScript action at page-level.