Skip to content

ENH: Add actions base class#3552

Open
j-t-1 wants to merge 201 commits into
py-pdf:mainfrom
j-t-1:actions
Open

ENH: Add actions base class#3552
j-t-1 wants to merge 201 commits into
py-pdf:mainfrom
j-t-1:actions

Conversation

@j-t-1
Copy link
Copy Markdown
Contributor

@j-t-1 j-t-1 commented Dec 6, 2025

Implement the JavaScript action at page-level.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.70%. Comparing base (228780a) to head (dde8004).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3552      +/-   ##
==========================================
+ Coverage   97.68%   97.70%   +0.01%     
==========================================
  Files          55       57       +2     
  Lines       10365    10454      +89     
  Branches     1913     1929      +16     
==========================================
+ Hits        10125    10214      +89     
  Misses        134      134              
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-t-1 j-t-1 marked this pull request as draft December 7, 2025 08:37
@j-t-1 j-t-1 marked this pull request as ready for review January 1, 2026 16:18
@stefan6419846 stefan6419846 added the needs-change The PR/issue cannot be handled as issue and needs to be improved label Jan 9, 2026
@j-t-1
Copy link
Copy Markdown
Contributor Author

j-t-1 commented Feb 17, 2026

@stefan6419846 ready for code review. The code coverage is picking up comments, I don't know if this is a real code coverage issue or not.

@stefan6419846
Copy link
Copy Markdown
Collaborator

Could you please have a look at the style failures and the coverage first?

@j-t-1
Copy link
Copy Markdown
Contributor Author

j-t-1 commented Feb 17, 2026

Could you please have a look at the style failures and the coverage first?

Yes will try and fix the style failures.

The coverage seems ok, and is even hightlighting comments.

@stefan6419846
Copy link
Copy Markdown
Collaborator

The coverage seems ok, and is even hightlighting comments.

Invalid trigger values are not covered correctly. Additionally, rebasing the code on the lastest main might help as the comment indicates that your branch is 42 commits behind, possibly leading to unexpected results.

Copy link
Copy Markdown
Contributor Author

@j-t-1 j-t-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan6419846 change str to TriggerType everywhere?

Comment thread tests/test_actions.py Outdated
Copy link
Copy Markdown
Contributor Author

@j-t-1 j-t-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefan6419846.

Comment thread pypdf/_page.py Outdated
Comment thread pypdf/_page.py Outdated
@j-t-1 j-t-1 requested a review from stefan6419846 May 21, 2026 11:51
Copy link
Copy Markdown
Contributor Author

@j-t-1 j-t-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Comment thread pypdf/actions/_actions.py Outdated
Comment thread pypdf/actions/_actions.py Outdated
Comment thread pypdf/actions/_actions.py Outdated
Comment thread pypdf/actions/_actions.py Outdated
Comment thread pypdf/actions/_actions.py Outdated
Comment thread pypdf/actions/_actions.py
Comment thread pypdf/_page.py Outdated
Comment thread tests/test_actions.py Outdated
Comment thread tests/test_actions.py Outdated
Comment thread tests/test_actions.py Outdated
j-t-1 and others added 15 commits May 21, 2026 14:21
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

@j-t-1 j-t-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @stefan6419846.

@j-t-1 j-t-1 requested a review from stefan6419846 May 21, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants