BUG: Use NumberObject for /Border elements of annotations

[rsinger417]

As defined in Table 164 – Entries common to all annotation dictionaries, the /Border Array consists of NumberObjects. Previously, pypdf used NameObject which is wrong.

The previous version caused a warning in the class NameObject method renumber "Incorrect first char in NameObject:({self})" line 592 _base.py (pypdf.generic)

Fixes #2444

[stefan6419846]

You do not need to open a new PR and close the old PR for each modification you do.

Could you please add a corresponding test case as well which shows the previous issue and demonstrates that your fix does indeed solve this? Apparently you would get warnings previously (#2447 (comment)), which might be something to check.

[rsinger417]

I'm sorry I have never done this before. I'm just learning by making a lot of mistakes. I deleted the branch after summiting the first PRs, which closed the PRs and lost the all of the code changes, so I made new PRs trying to fix the error. I made a pdf describing the bug in more detail with screen shots for you.
pydff PR #2447 more detail explanation of bug.pdf

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fb63f7) 94.43% compared to head (99e00a2) 94.43%.
Report is 1 commits behind head on main.

❗ Current head 99e00a2 differs from pull request most recent head b8f2ba3. Consider uploading reports for the commit b8f2ba3 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files          49       49           
  Lines        8008     8008           
  Branches     1616     1616           
=======================================
  Hits         7562     7562           
  Misses        276      276           
  Partials      170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MartinThoma]

Congratulations to your first accepted contribution @rsinger417 ! Thank you for helping to improve pypdf 🙏

If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)

[MartinThoma]

The fix will be released in pypdf > 4.01 (likely on Sunday, 18th of February)

[MartinThoma]

I like that the PR was small - especially for first contributions this is a good idea 👍

A few details to watch out for the next time. Don't worry, in this PR I took care of it already:

• PR title: This will be used for generating the CHANGELOG. Take one of the projects prefixes + add something short and descriptive.
• PR description: I try to take exactly the first posts description as a commit message. It should briefly describe the issue. If possible, reference the relevant part in the PDF specs.
• Tests: As stefan rightfully pointed out, having tests is always a good idea. In this specific case, having a section of the PDF specs was good enough to directly merge it.