fix(text_region): prevent font state leaking out of text_columns rendering#1849
Open
SAY-5 wants to merge 1 commit into
Open
fix(text_region): prevent font state leaking out of text_columns rendering#1849SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
ca0c11f to
7b78c17
Compare
Author
|
Reworked this: the snapshot/restore now lives in |
7b78c17 to
ced532a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1804
The render path inside
_render_styled_text_linemutatesself.font_size_ptto match each fragment but never restores it, sotext_columns()leaves the FPDF instance with the font size of the last rendered fragment. Snapshotcurrent_font,font_size_pt, andfont_styleat the start ofTextColumns.render()and restore them in afinallyblock.Checklist:
A unit test is covering the code added / modified by this PR
In case of a new feature, docstrings have been added, with also some documentation in the `docs/` folder
A mention of the change is present in `CHANGELOG.md`
This PR is ready to be merged
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.