Support rowspans taller than one page (#1460)#1820
Draft
jjudyyang wants to merge 4 commits into
Draft
Conversation
andersonhc
requested changes
May 19, 2026
Collaborator
andersonhc
left a comment
andersonhc
left a comment
There was a problem hiding this comment.
You have 3 files lingering at the root level of the project (overly_long_tablespan_29.pdf, overly_long_tablespan_30.pdf and repro_tablespan.py) please remove them or rewrite as tests if you judge they are relevant.
| with pdf.table(data, first_row_as_headings=False): | ||
| pass | ||
| assert_pdf_equal( | ||
| pdf, HERE / "table_rowspan_issue_1460_merged_cell_long_text_no_header.pdf", tmp_path |
Collaborator
There was a problem hiding this comment.
The actions pipeline is failing because this file has not been commited.
Comment on lines
+246
to
+259
| def test_table_rowspan_issue_1460_repeat_headings(tmp_path): | ||
| # Same as multipage case, but headings must repeat after each page break. | ||
| pdf = FPDF() | ||
| pdf.auto_page_break = True | ||
| pdf.set_font("Helvetica", size=12) | ||
| pdf.add_page() | ||
| with pdf.table( | ||
| _issue_1460_table_data(30), | ||
| repeat_headings=TableHeadingsDisplay.ON_TOP_OF_EVERY_PAGE, | ||
| ): | ||
| pass | ||
| assert_pdf_equal( | ||
| pdf, HERE / "table_rowspan_issue_1460_repeat_headings.pdf", tmp_path | ||
| ) |
Collaborator
There was a problem hiding this comment.
this test and test_table_rowspan_issue_1460_multipage() seem to produce identical files - you could even reference the same PDF. Maybe the idea was to test TableHeadingsDisplay.NONE to cover both paths?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rowspanis taller than a single page no longer raiseValueError; the span is drawn in per-row slices across pages (with borders extended through row gutters so vertical lines stay continuous)._pagebreak_space_before_row), instead of the full accumulatedpagebreak_heightof the entire rowspan._rowspan_merged_single_pass.ValueErrorwhen a single row is taller than the usable page (test_table_with_very_long_text).Tests
test/table/for multipage rowspan, repeated headings, and long text in a merged cell.Checklist:
Happy to add docs if this looks correct
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdThis PR is ready to be merged
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.