Skip to content

Fix table data px dimension parsing bug #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HrsLizo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix table data px dimension parsing bug #1788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fpdf/html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,6 +1125,9 @@ def handle_starttag(self, tag: str, attrs: list[tuple[str, str | None]]) -> None
if not self.table or not self.table_row:
raise FPDFException(f"Invalid HTML: <{tag}> used outside any <tr>")
self.td_th = {k.lower(): v for k, v in attrs_dict.items()}
for dimension in ("width", "height"):
if dimension in self.td_th and self.td_th[dimension] is not None:
self.td_th[dimension] = self.td_th[dimension].replace("px", "").strip()
Comment on lines +1128 to +1130
Copy link
Copy Markdown
Collaborator

@andersonhc andersonhc Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for dimension in ("width", "height"):
if dimension in self.td_th and self.td_th[dimension] is not None:
self.td_th[dimension] = self.td_th[dimension].replace("px", "").strip()
for dimension in ("width", "height"):
if dimension in self.td_th and self.td_th[dimension] is not None:
self.td_th[dimension] = self.td_th[dimension].replace("px", "").strip()

self.td_th["tag"] = tag
if tag == "th":
if "align" not in self.td_th:
Expand Down
Loading