Skip to content

Remediated PR#40 - #41

Open
CarlTSpeak wants to merge 4 commits into
pxlrbt:masterfrom
CarlTSpeak:fixes_fixed
Open

Remediated PR#40#41
CarlTSpeak wants to merge 4 commits into
pxlrbt:masterfrom
CarlTSpeak:fixes_fixed

Conversation

@CarlTSpeak

Copy link
Copy Markdown

Replaced function Get-Distros() with one that works. Fixed various formatting/syntax issues due to #40 being copy/paste direct from LLM window.

Snakefoxu and others added 4 commits December 26, 2025 20:06
…t#23 - v1.4.0

This PR addresses multiple open issues with the move-wsl script:

Bug Fixes:
- pxlrbt#37: Fixed script failing when only one distro is installed (improved parsing)
- pxlrbt#30/pxlrbt#35: Added automatic wsl --shutdown before export to prevent file locks
- pxlrbt#29: Default distro setting is now preserved after move

Enhancements:
- pxlrbt#23: Pre-check for NTFS compression on target folder (prevents corruption)
- Added CLI parameters for non-interactive mode: -Distro, -Target, -Force, -NoShutdown
- Improved visual feedback with colors and progress messages
- Shows distro info (WSL version, state, default status) during selection
- Displays export file size after completion

Technical:
- Replaced ConvertFrom-String with robust manual parsing
- Better error messages with recovery suggestions

Tested on Windows 11 with Debian WSL2 (276MB export/import cycle)
Replaced Get-Distros with function that works. Fixed various formatting issues due to original author copy/paste straight from LLM web interface.
@CarlTSpeak
CarlTSpeak marked this pull request as ready for review April 3, 2026 12:47
@pxlrbt

pxlrbt commented Apr 3, 2026

Copy link
Copy Markdown
Owner

"# Fixed poorly vibe-coded, untested Get-Distros function - now works"

This feels like you AI reviewed the AI code? Is that right?
I can't really test these changes as I don't have Windows anymore. So it's hard to merge it for me.

@CarlTSpeak

CarlTSpeak commented Apr 3, 2026

Copy link
Copy Markdown
Author

Not exactly, no. I left the rest of the code besides that one function that was broken. I cleaned up the copy/paste remnants manually.

The rest works as intended in my test so left it alone. Moved a Kali Linux image between drives.

I did not refactor it all, just one function.

All good if you aren't comfortable merging. I needed to move an image and saw that PR so fixed it. Thanks for responding 😊

@pxlrbt

pxlrbt commented Apr 3, 2026

Copy link
Copy Markdown
Owner

Thanks for the comment. I would leave this open for now, so others can find it and test. If more people confirm it's working, I might consider merging it without a test myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants