MODULES-11423: add zfs attribute defaultuserquota

[eg-roberts]

May we please add the zfs attribute 'defaultuserquota' to the zfs type/provider?

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

zfs is a type

Breaking changes to this file MAY impact these 4 modules (near match):

• counsyl-sys
• maxadamo-zfs_nas
• tedivm-hieratic
• hackerhorse-puppet_deluge

This module is declared in 1 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[joshcooper]

@eg-roberts thank you for your contribution! Could you sign the CLA?

[joshcooper]

Thanks @eg-roberts! This will need a few tweaks to wrap up.

Can you add newproperty(:defaultuserquota) to the zfs type here

puppetlabs-zfs_core/lib/puppet/type/zfs.rb

Lines 55 to 61 in 393b74c

	newproperty(:dedup) do
	desc 'The dedup property. Valid values are `on`, `off`.'
	end
	newproperty(:devices) do
	desc 'The devices property. Valid values are `on`, `off`.'
	end

Then use this rake task to autogenerate the reference:

$ bundle install
$ bundle exec rake strings:generate:reference
...

And include the modified REFERENCE.md in your commit.

[joshcooper]

Hi @eg-roberts friendly ping to see if you can update your PR?

[joshcooper]

@h0tw1r3 was the bcrypt native extension issue resolved? Maybe that was in bolt?

[h0tw1r3]

@h0tw1r3 was the bcrypt native extension issue resolved? Maybe that was in bolt?

@joshcooper, yes it was updated in Puppet runtime, puppetlabs/puppet-runtime#854
but still needs including in bolt puppetlabs/bolt#3248

[AriaXLi]

Hi again @h0tw1r3 thanks again for contributing! Like relatime, defaultuserquote attribute is causing some errors in CI that lead me to believe this attribute may also only be supported on Linux.

00:28:33   Error: Could not run: Execution of '/usr/sbin/zfs get -H -o value defaultuserquota tstpool/tstfs' returned 2: bad property list: invalid property 'defaultuserquota'
00:28:35   For more info, run: zfs help get

When you can, could you please update this PR too to account for this?
We have some other Linux-only properties that handle this in type (for overlay):

puppetlabs-zfs_core/lib/puppet/type/zfs.rb

Lines 83 to 89 in e16b1c2

	newproperty(:overlay) do
	desc 'The overlay property. Valid values are `on`, `off`.'
	validate do |_value|
	raise Puppet::Error _('This property is only supported on Linux') unless Facter.value(:kernel) == 'Linux'
	end
	end

Or in provider (for aclmode):

puppetlabs-zfs_core/lib/puppet/provider/zfs/zfs.rb

Lines 60 to 69 in e16b1c2

	[:aclmode, :acltype, :shareiscsi, :overlay].each do |field|
	# The zfs commands use the property value '-' to indicate that the
	# property is not set. We make use of this value to indicate that the
	# property is not set since it is not available. Conversely, if these
	# properties are attempted to be unset, and resulted in an error, our
	# best bet is to catch the exception and continue.
	define_method(field) do
	zfs(:get, '-H', '-o', 'value', field, @resource[:name]).strip
	rescue
	PARAMETER_UNSET_OR_NOT_AVAILABLE

[h0tw1r3]

@AriaXLi I'm not working at Puppet any longer and this is an internal CI issue. Someone else will need to pick this up.

[mhashizume]

Adding the "skip changelog" label to this PR since it was superseded by #83