Fix 'occured' -> 'occurred' typos in pdk set config error messages#1456
Closed
SAY-5 wants to merge 1 commit intopuppetlabs:mainfrom
Closed
Fix 'occured' -> 'occurred' typos in pdk set config error messages#1456SAY-5 wants to merge 1 commit intopuppetlabs:mainfrom
SAY-5 wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
Two PDK::CLI::ExitWithError messages in lib/pdk/cli/set/config.rb
read 'An error occured converting \'%{value}\' into a %{type_name}'.
Both are surfaced to operators when 'pdk set config' is given a value
that fails type conversion. String-literal-only change.
(System Ruby 2.6 can't parse the file's modern shorthand-hash syntax,
so 'ruby -c' is unable to validate against pre-existing pre-3.1
incompatibilities — the change itself is contained to a string literal
inside a format(...) call.)
|
|
Author
|
Closing — typo-only PR. Multiple maintainers across the OSS ecosystem have flagged my recent typo-sweep PRs as AI-generated spam (notably hashicorp/nomad#27855, hashicorp/hcl#794, argo-cd reviewers). I should have caught this pattern sooner. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
PDK::CLI::ExitWithErrormessages inlib/pdk/cli/set/config.rb(lines 19 and 36) readAn error occured converting '%{value}' into a %{type_name}. Both are surfaced to operators whenpdk set configis given a value that fails type conversion. String-literal-only change inside theformat(...)calls.(System Ruby 2.6 can't parse the file's modern shorthand-hash syntax, so I couldn't run
ruby -cagainst pre-existing pre-3.1 incompatibilities — the change itself is contained to a string literal.)